Revert "The current growth strategy for growable arrays allocates a backing array of size 2 at (emp…

Revert "The current growth strategy for growable arrays allocates a backing array of size 2 at (empty) creation and doubles the size whenever the capacity is insufficient while adding elements."

This reverts commit cec963f028198ec5871840491ba78b096ad0b819.

Fixes issue https://github.com/dart-lang/sdk/issues/30090, performance regression in GrowableList (severe for
dartdoc).

BUG=

[jcollins, 2017-07-06 15:31:46]

jcollins@google.com changed reviewers:
+ askesc@google.com, erikcorry@google.com

[jcollins, 2017-07-06 15:31:47]

jcollins@google.com changed required reviewers:
+ askesc@google.com

[jcollins, 2017-07-06 15:31:48]

It seems that the change to growable list expansion introduced a performance
regression that dartdoc hits pretty heavily.  I'm open to other solutions
besides reverting, but starting with that.

[jcollins, 2017-07-06 15:48:17]

Description was changed from

==========
Revert "The current growth strategy for growable arrays allocates a backing
array of size 2 at (empty) creation and doubles the size whenever the capacity
is insufficient while adding elements."

This reverts commit cec963f028198ec5871840491ba78b096ad0b819.

Fixes issue 30090, performance regression in GrowableList (severe for
dartdoc).

BUG=
==========

to

==========
Revert "The current growth strategy for growable arrays allocates a backing
array of size 2 at (empty) creation and doubles the size whenever the capacity
is insufficient while adding elements."

This reverts commit cec963f028198ec5871840491ba78b096ad0b819.

Fixes issue https://github.com/dart-lang/sdk/issues/30090, performance
regression in GrowableList (severe for
dartdoc).

BUG=
==========

[erikcorry, 2017-07-06 19:22:11]

Can you share a command line that we can use to repro the regression?

[erikcorry, 2017-07-06 19:22:46]

Ah, sorry, you did that on the bug!

[erikcorry, 2017-07-06 19:25:45]

lgtm

[Aske Simon Christensen, 2017-07-07 07:49:32]

lgtm

[erikcorry, 2017-07-07 12:20:03]

Please don't commit this.  We have a fix in
https://codereview.chromium.org/2971303002/
 instead