Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: runtime/vm/raw_object.h

Issue 2968003004: Revert "The current growth strategy for growable arrays allocates a backing array of size 2 at (emp… (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler_test.cc ('k') | runtime/vm/raw_object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index 36c61afd66dfdac2f1fb964679f44b89489c5a56..435988f7ed30097c09d74d813fce1361b686ce07 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -432,11 +432,11 @@ class RawObject {
intptr_t result = SizeTag::decode(tags);
if (result != 0) {
#if defined(DEBUG)
- // TODO(22501) Array::MakeFixedLength has a race with this code: we might
- // have loaded tags field and then MakeFixedLength could have updated it
- // leading to inconsistency between SizeFromClass() and
- // SizeTag::decode(tags). We are working around it by reloading tags_ and
- // recomputing size from tags.
+ // TODO(22501) Array::MakeArray has a race with this code: we might have
+ // loaded tags field and then MakeArray could have updated it leading
+ // to inconsistency between SizeFromClass() and SizeTag::decode(tags).
+ // We are working around it by reloading tags_ and recomputing
+ // size from tags.
const intptr_t size_from_class = SizeFromClass();
if ((result > size_from_class) && (GetClassId() == kArrayCid) &&
(ptr()->tags_ != tags)) {
« no previous file with comments | « runtime/vm/profiler_test.cc ('k') | runtime/vm/raw_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698