Revert "The current growth strategy for growable arrays allocates a backing array of size 2 at (emp…

runtime/lib/growable_array.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 
 #include "vm/assembler.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 
 namespace dart {
 
 DEFINE_NATIVE_ENTRY(GrowableList_allocate, 2) {
   const TypeArguments& type_arguments =
       TypeArguments::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Array, data, arguments->NativeArgAt(1));
-  if (data.Length() < 0) {
+  if (data.Length() <= 0) {
     Exceptions::ThrowRangeError("length",
                                 Integer::Handle(Integer::New(data.Length())),
                                 0,  // This is the limit the user sees.
                                 Array::kMaxElements);
   }
   const GrowableObjectArray& new_array =
       GrowableObjectArray::Handle(GrowableObjectArray::New(data));
   new_array.SetTypeArguments(type_arguments);
   return new_array.raw();
 }
@@ skipping 45 matching lines @@
   ASSERT((length.Value() >= 0) && (length.Value() <= array.Capacity()));
   array.SetLength(length.Value());
   return Object::null();
 }
 
 
 DEFINE_NATIVE_ENTRY(GrowableList_setData, 2) {
   const GrowableObjectArray& array =
       GrowableObjectArray::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Array, data, arguments->NativeArgAt(1));
-  ASSERT(data.Length() >= 0);
+  ASSERT(data.Length() > 0);
   array.SetData(data);
   return Object::null();
 }
 
 
 DEFINE_NATIVE_ENTRY(Internal_makeListFixedLength, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(GrowableObjectArray, array,
                                arguments->NativeArgAt(0));
-  return Array::MakeFixedLength(array, /* unique = */ true);
+  return Array::MakeArray(array);
 }
 
 
 DEFINE_NATIVE_ENTRY(Internal_makeFixedListUnmodifiable, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(Array, array, arguments->NativeArgAt(0));
   array.MakeImmutable();
   return array.raw();
 }
 
 }  // namespace dart