Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Side by Side Diff: runtime/vm/service.cc

Issue 2968003004: Revert "The current growth strategy for growable arrays allocates a backing array of size 2 at (emp… (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/raw_object.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service.h" 5 #include "vm/service.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "include/dart_native_api.h" 8 #include "include/dart_native_api.h"
9 #include "platform/globals.h" 9 #include "platform/globals.h"
10 10
(...skipping 2335 matching lines...) Expand 10 before | Expand all | Expand 10 after
2346 } 2346 }
2347 2347
2348 Zone* zone = thread->zone(); 2348 Zone* zone = thread->zone();
2349 const GrowableObjectArray& names = 2349 const GrowableObjectArray& names =
2350 GrowableObjectArray::Handle(zone, GrowableObjectArray::New()); 2350 GrowableObjectArray::Handle(zone, GrowableObjectArray::New());
2351 const GrowableObjectArray& values = 2351 const GrowableObjectArray& values =
2352 GrowableObjectArray::Handle(zone, GrowableObjectArray::New()); 2352 GrowableObjectArray::Handle(zone, GrowableObjectArray::New());
2353 if (BuildScope(thread, js, names, values)) { 2353 if (BuildScope(thread, js, names, values)) {
2354 return true; 2354 return true;
2355 } 2355 }
2356 const Array& names_array = Array::Handle(zone, Array::MakeFixedLength(names)); 2356 const Array& names_array = Array::Handle(zone, Array::MakeArray(names));
2357 const Array& values_array = 2357 const Array& values_array = Array::Handle(zone, Array::MakeArray(values));
2358 Array::Handle(zone, Array::MakeFixedLength(values));
2359 2358
2360 const String& expr_str = String::Handle(zone, String::New(expr)); 2359 const String& expr_str = String::Handle(zone, String::New(expr));
2361 ObjectIdRing::LookupResult lookup_result; 2360 ObjectIdRing::LookupResult lookup_result;
2362 Object& obj = 2361 Object& obj =
2363 Object::Handle(zone, LookupHeapObject(thread, target_id, &lookup_result)); 2362 Object::Handle(zone, LookupHeapObject(thread, target_id, &lookup_result));
2364 if (obj.raw() == Object::sentinel().raw()) { 2363 if (obj.raw() == Object::sentinel().raw()) {
2365 if (lookup_result == ObjectIdRing::kCollected) { 2364 if (lookup_result == ObjectIdRing::kCollected) {
2366 PrintSentinel(js, kCollectedSentinel); 2365 PrintSentinel(js, kCollectedSentinel);
2367 } else if (lookup_result == ObjectIdRing::kExpired) { 2366 } else if (lookup_result == ObjectIdRing::kExpired) {
2368 PrintSentinel(js, kExpiredSentinel); 2367 PrintSentinel(js, kExpiredSentinel);
(...skipping 2012 matching lines...) Expand 10 before | Expand all | Expand 10 after
4381 if (strcmp(method_name, method.name) == 0) { 4380 if (strcmp(method_name, method.name) == 0) {
4382 return &method; 4381 return &method;
4383 } 4382 }
4384 } 4383 }
4385 return NULL; 4384 return NULL;
4386 } 4385 }
4387 4386
4388 #endif // !PRODUCT 4387 #endif // !PRODUCT
4389 4388
4390 } // namespace dart 4389 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/raw_object.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698