Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2967543004: Revert of Created new target unit_tests in //media/formats. (Closed)

Created:
3 years, 5 months ago by paulmiller
Modified:
3 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Created new target unit_tests in //media/formats. (patchset #4 id:60001 of https://codereview.chromium.org/2888523002/ ) Reason for revert: broke official builds: https://crbug.com/737857 tried to fix here: https://codereview.chromium.org/2966573002/ but that's turning out to be complicated Original issue's description: > Created new target unit_tests in //media/formats. > > Created unit_tests target in //media/formats/BUILD.gn and moved the > respective unit_test changes from //media/BUILD.gn to > //media/formats/BUILD.gn. > > BUG=613033 > > R=jrummell@chromium.org, xhwang@chromium.org > > Review-Url: https://codereview.chromium.org/2888523002 > Cr-Commit-Position: refs/heads/master@{#474743} > Committed: https://chromium.googlesource.com/chromium/src/+/b0fc11f9713bc1e54f94a2f23690cfc565f73ea0 TBR=dalecurtis@chromium.org,a.suchit@chromium.org,jrummell@chromium.org,xhwang@chromium.org,a.suchit@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=613033 Review-Url: https://codereview.chromium.org/2967543004 Cr-Commit-Position: refs/heads/master@{#483610} Committed: https://chromium.googlesource.com/chromium/src/+/7c848f01ca9008e1a63c477df8980857eece1183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -67 lines) Patch
M media/BUILD.gn View 4 chunks +45 lines, -1 line 0 comments Download
M media/formats/BUILD.gn View 1 chunk +0 lines, -66 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
paulmiller
Created Revert of Created new target unit_tests in //media/formats.
3 years, 5 months ago (2017-06-30 00:54:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967543004/1
3 years, 5 months ago (2017-06-30 00:54:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7c848f01ca9008e1a63c477df8980857eece1183
3 years, 5 months ago (2017-06-30 03:08:15 UTC) #6
a.suchit2
On 2017/06/30 03:08:15, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 5 months ago (2017-06-30 03:15:53 UTC) #7
DaleCurtis
3 years, 5 months ago (2017-06-30 17:01:13 UTC) #8
Message was sent while issue was closed.
Thanks; sorry for the trouble. Looks like somehow we're pulling in multiple
copies of the source_set() which results in double linking. I don't see anything
wrong with the //media/formats CL, so I think it's some mulitplicative affect
with the media/filters one. Will see about figuring out what's going on.

Powered by Google App Engine
This is Rietveld 408576698