Fix media/formats:unit_tests build

Fix media/formats:unit_tests build

These tests were moved from //media:unit_tests to
//media/formats:unit_tests, but the new target doesn't depend on
//media:media_features, so the required media_features.h may not be
generated.

BUG=737857

[paulmiller, 2017-06-29 19:22:18]

Description was changed from

==========
Fix media/formats:unit_tests build

These tests were moved from //media:unit_tests to
//media/formats:unit_tests, but the new target doesn't depend on
//media:media_features, so the required media_features.h may not be
generated.

BUG=737857
==========

to

==========
Fix media/formats:unit_tests build

These tests were moved from //media:unit_tests to
//media/formats:unit_tests, but the new target doesn't depend on
//media:media_features, so the required media_features.h may not be
generated.

BUG=737857
==========

[paulmiller, 2017-06-29 19:22:19]

paulmiller@chromium.org changed reviewers:
+ jrummell@chromium.org

[paulmiller, 2017-06-29 19:22:46]

On 2017/06/29 19:22:19, paulmiller wrote:
> mailto:paulmiller@chromium.org changed reviewers:
> + mailto:jrummell@chromium.org

PTAL

[paulmiller, 2017-06-29 20:32:45]

paulmiller@chromium.org changed reviewers:
+ dalecurtis@chromium.org, xhwang@chromium.org

[paulmiller, 2017-06-29 20:33:12]

+ some more owners

[DaleCurtis, 2017-06-29 20:51:48]

lgtm

[jrummell, 2017-06-29 21:36:16]

lgtm

[paulmiller, 2017-06-29 21:37:24]

The CQ bit was checked by paulmiller@chromium.org

[commit-bot: I haz the power, 2017-06-29 21:38:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 21:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 21:56:11]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[paulmiller, 2017-06-29 22:23:13]

On 2017/06/29 21:56:11, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Undefined reference to vpx_codec_vp9_dx & vpx_codec_get_caps. So it seems there
are some other missing dependencies.

[DaleCurtis, 2017-06-29 22:26:47]

Weird, those should be fixed by adding a section to media/base/BUILD.gn that
says:

if (media_use_libvpx) {
  deps += [ "//third_party/libvpx" ]
}

[DaleCurtis, 2017-06-29 22:27:20]

Similar to this one
https://cs.chromium.org/chromium/src/media/base/BUILD.gn?q=decode_capabilitie...

[paulmiller, 2017-06-29 22:47:12]

The CQ bit was checked by paulmiller@chromium.org

[paulmiller, 2017-06-29 22:47:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2966573002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-29 22:47:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 00:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 00:25:28]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[paulmiller, 2017-06-30 00:48:14]

On 2017/06/30 00:25:28, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

"media.dll.lib(media.dll) : error LNK2005: "public: __thiscall
media::CdmKeyInformation::~CdmKeyInformation(void)"
(??1CdmKeyInformation@media@@QAE@XZ) already defined in cdm_key_information.obj"
:/

[a.suchit2, 2017-06-30 03:39:48]

On 2017/06/30 00:48:14, paulmiller wrote:
> On 2017/06/30 00:25:28, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
> 
> "media.dll.lib(media.dll) : error LNK2005: "public: __thiscall
> media::CdmKeyInformation::~CdmKeyInformation(void)"
> (??1CdmKeyInformation@media@@QAE@XZ) already defined in
cdm_key_information.obj"
> :/

Please share the problem/error in the official build.

[paulmiller, 2017-06-30 17:22:26]

> Please share the problem/error in the official build.

See the bug for the official build error. I assume it doesn't show up on the
trybots, or the original patch wouldn't have landed. This is the fix for the
official build error, but as you can see, it creates some new errors.

[a.suchit2, 2017-06-30 19:04:30]

On 2017/06/30 17:22:26, paulmiller wrote:
> > Please share the problem/error in the official build.
> 
> See the bug for the official build error. I assume it doesn't show up on the
> trybots, or the original patch wouldn't have landed. This is the fix for the
> official build error, but as you can see, it creates some new errors.

I do not have access for this bug.

[paulmiller, 2017-06-30 20:18:43]

On 2017/06/30 19:04:30, a.suchit2 wrote:
> On 2017/06/30 17:22:26, paulmiller wrote:
> > > Please share the problem/error in the official build.
> > 
> > See the bug for the official build error. I assume it doesn't show up on the
> > trybots, or the original patch wouldn't have landed. This is the fix for the
> > official build error, but as you can see, it creates some new errors.
> 
> I do not have access for this bug.

It was:

FAILED: obj/media/formats/unit_tests/sample_to_group_iterator_unittest.o
...
In file included from
../../media/formats/mp4/sample_to_group_iterator_unittest.cc:5:
In file included from ../../media/formats/mp4/sample_to_group_iterator.h:13:
In file included from ../../media/formats/mp4/box_definitions.h:17:
In file included from ../../media/base/media_log.h:20:
In file included from ../../media/base/pipeline_impl.h:15:
In file included from ../../media/base/pipeline.h:15:
In file included from ../../media/base/media_track.h:11:
In file included from ../../media/base/stream_parser.h:22:
../../media/base/eme_constants.h:10:10: fatal error: 'media/media_features.h'
file not found
#include "media/media_features.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

media_features.h is out/.../gen/media/media_features.h. It's generated by the
//media:media_features build step, on which //media/formats:formats depends.