Created new target unit_tests in //media/formats.

Created new target unit_tests in //media/formats.

Created unit_tests target in //media/formats/BUILD.gn and moved the
respective unit_test changes from //media/BUILD.gn to
//media/formats/BUILD.gn.

BUG=613033
R=jrummell@chromium.org, xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2888523002
Cr-Commit-Position: refs/heads/master@{#474743}
Committed: https://chromium.googlesource.com/chromium/src/+/b0fc11f9713bc1e54f94a2f23690cfc565f73ea0

[a.suchit2, 2017-05-16 12:02:45]

a.suchit@chromium.org changed reviewers:
+ a.suchit@chromium.org

[a.suchit2, 2017-05-17 00:24:16]

On 2017/05/16 12:02:45, a.suchit2 wrote:

This patch also working fine on Linux.
Needs to check on other systems using buildbots.
It can be checked only after first patch is landed.

[a.suchit2, 2017-05-24 03:18:28]

Description was changed from

==========
Created new target unit_tests in //media/formats.

Created unit_tests target in //media/formats/BUILD.gn and moved the
respective unit_test changes from //media/BUILD.gn to
//media/formats/BUILD.gn.

BUG=613033

R=jrummell@chromium.org, xhwang@chromium.org
==========

to

==========
Created new target unit_tests in //media/formats.

Created unit_tests target in //media/formats/BUILD.gn and moved the
respective unit_test changes from //media/BUILD.gn to
//media/formats/BUILD.gn.

BUG=613033

R=jrummell@chromium.org, xhwang@chromium.org
==========

[a.suchit2, 2017-05-24 03:18:28]

a.suchit@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[a.suchit2, 2017-05-24 04:27:45]

The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 04:28:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 05:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 05:35:29]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[a.suchit2, 2017-05-24 07:02:09]

The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 07:02:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 09:14:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 09:14:43]

Dry run: This issue passed the CQ dry run.

[a.suchit2, 2017-05-24 10:11:42]

Please review. Thanks

https://codereview.chromium.org/2888523002/diff/40001/media/formats/BUILD.gn
File media/formats/BUILD.gn (right):

https://codereview.chromium.org/2888523002/diff/40001/media/formats/BUILD.gn#...
media/formats/BUILD.gn:151: testonly = true
Should it have visibility ?

visibility = [ "//media/*" ]

[DaleCurtis, 2017-05-24 18:04:27]

https://codereview.chromium.org/2888523002/diff/40001/media/formats/BUILD.gn
File media/formats/BUILD.gn (right):

https://codereview.chromium.org/2888523002/diff/40001/media/formats/BUILD.gn#...
media/formats/BUILD.gn:151: testonly = true
On 2017/05/24 at 10:11:42, a.suchit2 wrote:
> Should it have visibility ?
> 
> visibility = [ "//media/*" ]

Yes I think so; does that fail right now?

[a.suchit2, 2017-05-24 23:47:47]

https://codereview.chromium.org/2888523002/diff/40001/media/formats/BUILD.gn
File media/formats/BUILD.gn (right):

https://codereview.chromium.org/2888523002/diff/40001/media/formats/BUILD.gn#...
media/formats/BUILD.gn:151: testonly = true
On 2017/05/24 18:04:27, DaleCurtis wrote:
> On 2017/05/24 at 10:11:42, a.suchit2 wrote:
> > Should it have visibility ?
> > 
> > visibility = [ "//media/*" ]
> 
> Yes I think so; does that fail right now?

It would not fail after adding visibility Because it is used in media only.

[DaleCurtis, 2017-05-25 00:29:45]

https://codereview.chromium.org/2888523002/diff/40001/media/formats/BUILD.gn
File media/formats/BUILD.gn (right):

https://codereview.chromium.org/2888523002/diff/40001/media/formats/BUILD.gn#...
media/formats/BUILD.gn:151: testonly = true
On 2017/05/24 at 23:47:47, a.suchit2 wrote:
> On 2017/05/24 18:04:27, DaleCurtis wrote:
> > On 2017/05/24 at 10:11:42, a.suchit2 wrote:
> > > Should it have visibility ?
> > > 
> > > visibility = [ "//media/*" ]
> > 
> > Yes I think so; does that fail right now?
> 
> It would not fail after adding visibility Because it is used in media only.

Okay, lets add it then.

[a.suchit2, 2017-05-25 07:37:14]

The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 07:37:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 09:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 09:30:42]

Dry run: This issue passed the CQ dry run.

[a.suchit2, 2017-05-25 09:50:48]

https://codereview.chromium.org/2888523002/diff/40001/media/formats/BUILD.gn
File media/formats/BUILD.gn (right):

https://codereview.chromium.org/2888523002/diff/40001/media/formats/BUILD.gn#...
media/formats/BUILD.gn:151: testonly = true
On 2017/05/25 00:29:45, DaleCurtis wrote:
> On 2017/05/24 at 23:47:47, a.suchit2 wrote:
> > On 2017/05/24 18:04:27, DaleCurtis wrote:
> > > On 2017/05/24 at 10:11:42, a.suchit2 wrote:
> > > > Should it have visibility ?
> > > > 
> > > > visibility = [ "//media/*" ]
> > > 
> > > Yes I think so; does that fail right now?
> > 
> > It would not fail after adding visibility Because it is used in media only.
> 
> Okay, lets add it then.

Done.

[DaleCurtis, 2017-05-25 18:37:43]

lgtm

[a.suchit2, 2017-05-25 19:10:17]

The CQ bit was checked by a.suchit@chromium.org

[commit-bot: I haz the power, 2017-05-25 19:10:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 19:16:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495739417289490,
"parent_rev": "f349c9b994da59b72249f082fd8de5b7a5856e01", "commit_rev":
"b0fc11f9713bc1e54f94a2f23690cfc565f73ea0"}

[commit-bot: I haz the power, 2017-05-25 19:16:16]

Description was changed from

==========
Created new target unit_tests in //media/formats.

Created unit_tests target in //media/formats/BUILD.gn and moved the
respective unit_test changes from //media/BUILD.gn to
//media/formats/BUILD.gn.

BUG=613033

R=jrummell@chromium.org, xhwang@chromium.org
==========

to

==========
Created new target unit_tests in //media/formats.

Created unit_tests target in //media/formats/BUILD.gn and moved the
respective unit_test changes from //media/BUILD.gn to
//media/formats/BUILD.gn.

BUG=613033

R=jrummell@chromium.org, xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2888523002
Cr-Commit-Position: refs/heads/master@{#474743}
Committed:
https://chromium.googlesource.com/chromium/src/+/b0fc11f9713bc1e54f94a2f23690...
==========

[commit-bot: I haz the power, 2017-05-25 19:16:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b0fc11f9713bc1e54f94a2f23690...

[paulmiller, 2017-06-30 00:54:12]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2967543004/ by paulmiller@chromium.org.

The reason for reverting is: broke official builds: https://crbug.com/737857
tried to fix here: https://codereview.chromium.org/2966573002/ but that's
turning out to be complicated.