Prevent media controls from auto-hiding on audio-only content.

Prevent media controls from auto-hiding on audio-only content.

BUG=374959
TEST=LayoutTests/media/audio-controls-do-not-fade-out.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174587

[acolwell GONE FROM CHROMIUM, 2014-05-22 00:17:01]

https://codereview.chromium.org/296743007/diff/1/LayoutTests/media/audio-cont...
File LayoutTests/media/audio-controls-do-not-fade-out.html (right):

https://codereview.chromium.org/296743007/diff/1/LayoutTests/media/audio-cont...
LayoutTests/media/audio-controls-do-not-fade-out.html:9: <audio id="audio"
controls autoplay src="content/test.oga"></audio><br>
Changed to a file longer than 3 seconds so the controls have a chance to hide.

https://codereview.chromium.org/296743007/diff/1/LayoutTests/media/audio-cont...
LayoutTests/media/audio-controls-do-not-fade-out.html:21: var controls =
mediaControlsElement(internals.shadowRoot(e.target).firstChild,
"-webkit-media-controls-panel");
The old code was looking at the wrong element which is why the regression was
not detected. This is less brittle than the firstChild.firstChild business in
the old code.

[philipj_slow, 2014-05-22 11:51:38]

lgtm

https://codereview.chromium.org/296743007/diff/1/LayoutTests/media/audio-cont...
File LayoutTests/media/audio-controls-do-not-fade-out.html (right):

https://codereview.chromium.org/296743007/diff/1/LayoutTests/media/audio-cont...
LayoutTests/media/audio-controls-do-not-fade-out.html:21: var controls =
mediaControlsElement(internals.shadowRoot(e.target).firstChild,
"-webkit-media-controls-panel");
On 2014/05/22 00:17:02, acolwell wrote:
> The old code was looking at the wrong element which is why the regression was
> not detected. This is less brittle than the firstChild.firstChild business in
> the old code.

Interesting. I can see three other tests using the same pattern:
track/track-cue-rendering-snap-to-lines-not-set.html:86:           
controlsPanelElement = internals.shadowRoot(video).firstChild.firstChild;
video-controls-in-media-document.html:13:    controls =
internals.shadowRoot(video).firstChild.firstChild;
video-controls-no-scripting.html:15:            controls = 
internals.shadowRoot(video).firstChild.firstChild;

Those would be nice to fix, I've made a note about it but will not get around to
it right now.

[commit-bot: I haz the power, 2014-05-22 11:52:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/acolwell@chromium.org/296743007/1

[fs, 2014-05-22 12:13:29]

On 2014/05/22 11:51:38, philipj wrote:
> lgtm
> 
>
https://codereview.chromium.org/296743007/diff/1/LayoutTests/media/audio-cont...
> File LayoutTests/media/audio-controls-do-not-fade-out.html (right):
> 
>
https://codereview.chromium.org/296743007/diff/1/LayoutTests/media/audio-cont...
> LayoutTests/media/audio-controls-do-not-fade-out.html:21: var controls =
> mediaControlsElement(internals.shadowRoot(e.target).firstChild,
> "-webkit-media-controls-panel");
> On 2014/05/22 00:17:02, acolwell wrote:
> > The old code was looking at the wrong element which is why the regression
was
> > not detected. This is less brittle than the firstChild.firstChild business
in
> > the old code.
> 
> Interesting. I can see three other tests using the same pattern:
> track/track-cue-rendering-snap-to-lines-not-set.html:86:           
> controlsPanelElement = internals.shadowRoot(video).firstChild.firstChild;
> video-controls-in-media-document.html:13:    controls =
> internals.shadowRoot(video).firstChild.firstChild;
> video-controls-no-scripting.html:15:            controls = 
> internals.shadowRoot(video).firstChild.firstChild;
> 
> Those would be nice to fix, I've made a note about it but will not get around
to
> it right now.

In https://codereview.chromium.org/294963003 I factored the "lookup" code into a
utility method (mediaControlButton, poor name for this usecase maybe...). Using
that this would become (IIRC):

controls = mediaControlButton(video, "panel");

[commit-bot: I haz the power, 2014-05-22 18:58:30]

Change committed as 174587