Issue 294963003: MediaVolumeSliderPart is not vertical

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294963003: MediaVolumeSliderPart is not vertical (Closed)

Created:
6 years, 7 months ago by fs

Modified:
6 years, 7 months ago

Reviewers:
keishi, tkent, acolwell GONE FROM CHROMIUM

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

MediaVolumeSliderPart is not vertical This makes some parts of the keymapping a bit more intuitive for the volume-slider of media controls (-webkit-appearance: media-volume-slider). BUG=135661 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174503

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -7 lines)			Patch
A	LayoutTests/media/controls-volume-slider-keynav.html	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
A	LayoutTests/media/controls-volume-slider-keynav-expected.txt	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	LayoutTests/media/media-controls.js	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
M	Source/core/html/forms/RangeInputType.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (0 generated)

On 2014/05/21 00:51:56, tkent wrote: > Can you add a test? Added. PTAL.

6 years, 7 months ago (2014-05-21 07:51:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/294963003/20001

6 years, 7 months ago (2014-05-21 17:52:53 UTC) #7

Message was sent while issue was closed.

Change committed as 174503