Source/core/html/shadow/MediaControls.cpp - Issue 296743007: Prevent media controls from auto-hiding on audio-only content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.cpp

Issue 296743007: Prevent media controls from auto-hiding on audio-only content. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/MediaControls.cpp

diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp

index 1b1a234275e528d7ea759827b70eb757ce30ff7e..da85c339edcb67a3f936b61aa38a542b4bd2217f 100644

--- a/Source/core/html/shadow/MediaControls.cpp

+++ b/Source/core/html/shadow/MediaControls.cpp

@@ -209,7 +209,7 @@ void MediaControls::makeTransparent()

bool MediaControls::shouldHideMediaControls()

{

- return !m_panel->hovered();

+ return !m_panel->hovered() && mediaElement().hasVideo();

}

void MediaControls::playbackStarted()