Be explicit about namespace testing to not mix it with blink::testing

Be explicit about namespace testing to not mix it with blink::testing

There are two namespaces named testing used in Blink unit tests, one
from gtest and one internal helper namespace. If both are visible then
the gtest testing namespace won't be used unless prepended with ::, as
is already done in large parts of the code.

BUG=739121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2967013002
Cr-Commit-Position: refs/heads/master@{#484966}
Committed: https://chromium.googlesource.com/chromium/src/+/c04dbb714b62253db69c04d7671b2c58af1fccf9

[Daniel Bratell, 2017-07-04 10:13:42]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[Daniel Bratell, 2017-07-04 10:13:45]

Description was changed from

==========
Be explicit about namespace testing to not mix it with blink::testing

There are two namespaces named testing used in Blink unit tests, one
from gtest and one internal helper namespace. If both are visible then
the gtest testing namespace won't be used unless prepended with ::, as
is already done in large parts of the code.

BUG=739121
==========

to

==========
Be explicit about namespace testing to not mix it with blink::testing

There are two namespaces named testing used in Blink unit tests, one
from gtest and one internal helper namespace. If both are visible then
the gtest testing namespace won't be used unless prepended with ::, as
is already done in large parts of the code.

BUG=739121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-07-04 10:13:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 12:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 12:09:57]

Dry run: This issue passed the CQ dry run.

[Daniel Bratell, 2017-07-05 12:01:49]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 12:01:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 13:31:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 13:31:38]

Dry run: This issue passed the CQ dry run.

[Daniel Bratell, 2017-07-07 12:25:54]

bratell@opera.com changed reviewers:
+ dpranke@chromium.org, haraken@chromium.org

[Daniel Bratell, 2017-07-07 12:25:55]

haraken, can you take a look?

In general, maybe it would have been better to not have a blink::testing
namespace but it would have been an equally big patch for that.

This is just preparing for another patch that would make jumbo available for
platform/modules/public unit_tests. Without this, dozens of files would have to
be manually excluded from jumbo to make it compile.

[haraken, 2017-07-07 12:52:15]

LGTM

[Daniel Bratell, 2017-07-07 13:55:24]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2017-07-07 13:55:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 13:59:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 13:59:29]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Daniel Bratell, 2017-07-07 14:20:58]

The CQ bit was checked by bratell@opera.com

[Daniel Bratell, 2017-07-07 14:20:59]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2967013002/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2017-07-07 14:21:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 14:32:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 14:32:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Daniel Bratell, 2017-07-07 15:42:14]

The CQ bit was checked by bratell@opera.com

[Daniel Bratell, 2017-07-07 15:42:17]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2967013002/#ps80001
(title: "Dropped mojo parts that need another review.")

[commit-bot: I haz the power, 2017-07-07 15:42:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 17:37:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499442134128600,
"parent_rev": "3974209c4ba3659bbfcbd8ea30a6fcc7b4ffb178", "commit_rev":
"c04dbb714b62253db69c04d7671b2c58af1fccf9"}

[commit-bot: I haz the power, 2017-07-07 17:37:52]

Description was changed from

==========
Be explicit about namespace testing to not mix it with blink::testing

There are two namespaces named testing used in Blink unit tests, one
from gtest and one internal helper namespace. If both are visible then
the gtest testing namespace won't be used unless prepended with ::, as
is already done in large parts of the code.

BUG=739121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Be explicit about namespace testing to not mix it with blink::testing

There are two namespaces named testing used in Blink unit tests, one
from gtest and one internal helper namespace. If both are visible then
the gtest testing namespace won't be used unless prepended with ::, as
is already done in large parts of the code.

BUG=739121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2967013002
Cr-Commit-Position: refs/heads/master@{#484966}
Committed:
https://chromium.googlesource.com/chromium/src/+/c04dbb714b62253db69c04d7671b...
==========

[commit-bot: I haz the power, 2017-07-07 17:37:58]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c04dbb714b62253db69c04d7671b...

[Dirk Pranke, 2017-07-07 20:02:03]

lgtm also.