third_party/WebKit/Source/platform/WebIconSizesParserTest.cpp - Issue 2967013002: Be explicit about namespace testing to not mix it with blink::testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/WebIconSizesParserTest.cpp

Issue 2967013002: Be explicit about namespace testing to not mix it with blink::testing (Closed)

Patch Set: Dropped mojo parts that need another review. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/WebIconSizesParserTest.cpp

diff --git a/third_party/WebKit/Source/platform/WebIconSizesParserTest.cpp b/third_party/WebKit/Source/platform/WebIconSizesParserTest.cpp

index e2eef2c8baeb9c9cf2581da59a62df54d7040205..74d2535b2a8ca208221b67e083eb522e067ff500 100644

--- a/third_party/WebKit/Source/platform/WebIconSizesParserTest.cpp

+++ b/third_party/WebKit/Source/platform/WebIconSizesParserTest.cpp

@@ -11,7 +11,7 @@

namespace blink {

-class WebIconSizesParserTest : public testing::Test {};

+class WebIconSizesParserTest : public ::testing::Test {};

TEST(WebIconSizesParserTest, parseSizes) {

WebString sizes_attribute = "32x33";