Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 2966493005: Turn MediaLog usage from plain wrong into questionable (Closed)

Created:
3 years, 5 months ago by wdzierzanowski
Modified:
3 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn MediaLog usage from plain wrong into questionable ReadConcatentatedBoxes() was handing out BoxReader instances that referred to MediaLog objects that had gone out of scope. BUG=712310 Review-Url: https://codereview.chromium.org/2966493005 Cr-Commit-Position: refs/heads/master@{#483840} Committed: https://chromium.googlesource.com/chromium/src/+/777668278d3487a6c1cabde6bea0991b95b5007d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M media/cdm/cenc_utils.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M media/formats/mp4/box_reader.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/formats/mp4/box_reader.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
wdzierzanowski
Going for the lesser evil here, as I don't want to rewrite too much of ...
3 years, 5 months ago (2017-06-30 07:49:08 UTC) #2
DaleCurtis
Whoops, thanks. Agreed with approach. lgtm
3 years, 5 months ago (2017-06-30 17:50:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966493005/1
3 years, 5 months ago (2017-06-30 19:45:47 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 22:14:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/777668278d3487a6c1cabde6bea0...

Powered by Google App Engine
This is Rietveld 408576698