Turn MediaLog usage from plain wrong into questionable

media/formats/mp4/box_reader.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/formats/mp4/box_reader.h"
 
 #include <stddef.h>
 #include <string.h>
 
 #include <algorithm>
@@ skipping 139 matching lines @@
     *err = true;
     return false;
   }
   *type = reader.type();
   *box_size = reader.box_size();
   return true;
 }
 
 // static
 BoxReader* BoxReader::ReadConcatentatedBoxes(const uint8_t* buf,
-                                             const size_t buf_size) {
-  // TODO(wolenetz): Questionable MediaLog usage, http://crbug.com/712310
-  MediaLog media_log;
-  BoxReader* reader = new BoxReader(buf, buf_size, &media_log, true);
+                                             const size_t buf_size,
+                                             MediaLog* media_log) {
+  BoxReader* reader = new BoxReader(buf, buf_size, media_log, true);
 
   // Concatenated boxes are passed in without a wrapping parent box. Set
   // |box_size_| to the concatenated buffer length to mimic having already
   // parsed the parent box.
   reader->box_size_ = buf_size;
   reader->box_size_known_ = true;
 
   return reader;
 }
 
@@ skipping 124 matching lines @@
 
   // Note that the pos_ head has advanced to the byte immediately after the
   // header, which is where we want it.
   box_size_ = base::checked_cast<size_t>(box_size);
   box_size_known_ = true;
   return true;
 }
 
 }  // namespace mp4
 }  // namespace media