Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: media/formats/mp4/box_reader.cc

Issue 2966493005: Turn MediaLog usage from plain wrong into questionable (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/mp4/box_reader.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/box_reader.cc
diff --git a/media/formats/mp4/box_reader.cc b/media/formats/mp4/box_reader.cc
index a6f94c91114548bcb7b840f367613779c6f21db0..8e22539ee3179ab730f106c462fae05a098b03d2 100644
--- a/media/formats/mp4/box_reader.cc
+++ b/media/formats/mp4/box_reader.cc
@@ -157,10 +157,9 @@ bool BoxReader::StartTopLevelBox(const uint8_t* buf,
// static
BoxReader* BoxReader::ReadConcatentatedBoxes(const uint8_t* buf,
- const size_t buf_size) {
- // TODO(wolenetz): Questionable MediaLog usage, http://crbug.com/712310
- MediaLog media_log;
- BoxReader* reader = new BoxReader(buf, buf_size, &media_log, true);
+ const size_t buf_size,
+ MediaLog* media_log) {
+ BoxReader* reader = new BoxReader(buf, buf_size, media_log, true);
// Concatenated boxes are passed in without a wrapping parent box. Set
// |box_size_| to the concatenated buffer length to mimic having already
« no previous file with comments | « media/formats/mp4/box_reader.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698