Reland of [vr] Ensure that textured elements never draw with a dirty texture

Reland of [vr] Ensure that textured elements never draw with a dirty texture (patchset #1 id:1 of https://codereview.chromium.org/2972843002/ )

Reason for revert:
Reverting this CL did fix errors on the FYI bot, but I cannot reproduce
them on ToT. New fixes / issues may have been introduced. Since this
is blocking progress, I'm going to resubmit and try and find a
reproduction offline.

Original issue's description:
> Revert of [vr] Ensure that textured elements never draw with a dirty texture (patchset #2 id:20001 of https://codereview.chromium.org/2969023003/ )
> 
> Reason for revert:
> Breaks some VR browser navigation tests due to failing DCHECK https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbuilds=200
> 
> Original issue's description:
> > [vr] Ensure that textured elements never draw with a dirty texture
> > 
> > This should never be possible, so I've made UpdateTexture a part
> > of OnBeginFrame. It will usually early out (because the texture won't
> > be dirty), but will ensure that we never again draw with a dirty
> > texture. I've also added a DCHECK to ensure that we don't change this.
> > 
> > NB: this has no impact on the the update throttling done by the URL
> > bar since it has its own overridden implementation of OnBeginFrame.
> > 
> > BUG=None
> > 
> > Review-Url: https://codereview.chromium.org/2969023003
> > Cr-Commit-Position: refs/heads/master@{#484142}
> > Committed: https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba933e0c3dc2405
> 
> TBR=cjgrant@chromium.org,vollick@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=None
> 
> Review-Url: https://codereview.chromium.org/2972843002
> Cr-Commit-Position: refs/heads/master@{#484300}
> Committed: https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a477411d93a42c58e

TBR=cjgrant@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None

Review-Url: https://codereview.chromium.org/2965413002
Cr-Commit-Position: refs/heads/master@{#484985}
Committed: https://chromium.googlesource.com/chromium/src/+/c4d9ba2e2790ecb45344f3b3967b0d5e3af5b5c4

[Ian Vollick, 2017-07-07 17:25:16]

The CQ bit was checked by vollick@chromium.org

[Ian Vollick, 2017-07-07 17:25:16]

Created Reland of [vr] Ensure that textured elements never draw with a dirty
texture

[commit-bot: I haz the power, 2017-07-07 17:25:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ian Vollick, 2017-07-07 17:28:15]

The CQ bit was unchecked by vollick@chromium.org

[Ian Vollick, 2017-07-07 17:28:43]

Description was changed from

==========
Reland of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #1 id:1 of https://codereview.chromium.org/2972843002/ )

Reason for revert:
These failures seem to persist on ToT.

Original issue's description:
> Revert of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #2 id:20001 of https://codereview.chromium.org/2969023003/ )
> 
> Reason for revert:
> Breaks some VR browser navigation tests due to failing DCHECK
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbu...
> 
> Original issue's description:
> > [vr] Ensure that textured elements never draw with a dirty texture
> > 
> > This should never be possible, so I've made UpdateTexture a part
> > of OnBeginFrame. It will usually early out (because the texture won't
> > be dirty), but will ensure that we never again draw with a dirty
> > texture. I've also added a DCHECK to ensure that we don't change this.
> > 
> > NB: this has no impact on the the update throttling done by the URL
> > bar since it has its own overridden implementation of OnBeginFrame.
> > 
> > BUG=None
> > 
> > Review-Url: https://codereview.chromium.org/2969023003
> > Cr-Commit-Position: refs/heads/master@{#484142}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba9...
> 
> TBR=cjgrant@chromium.org,vollick@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=None
> 
> Review-Url: https://codereview.chromium.org/2972843002
> Cr-Commit-Position: refs/heads/master@{#484300}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a4774...

TBR=cjgrant@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
==========

to

==========
Reland of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #1 id:1 of https://codereview.chromium.org/2972843002/ )

Reason for revert:
I am not able to reproduce the errors locally. Will try and
fix this FYI bot offline.

Original issue's description:
> Revert of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #2 id:20001 of https://codereview.chromium.org/2969023003/ )
> 
> Reason for revert:
> Breaks some VR browser navigation tests due to failing DCHECK
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbu...
> 
> Original issue's description:
> > [vr] Ensure that textured elements never draw with a dirty texture
> > 
> > This should never be possible, so I've made UpdateTexture a part
> > of OnBeginFrame. It will usually early out (because the texture won't
> > be dirty), but will ensure that we never again draw with a dirty
> > texture. I've also added a DCHECK to ensure that we don't change this.
> > 
> > NB: this has no impact on the the update throttling done by the URL
> > bar since it has its own overridden implementation of OnBeginFrame.
> > 
> > BUG=None
> > 
> > Review-Url: https://codereview.chromium.org/2969023003
> > Cr-Commit-Position: refs/heads/master@{#484142}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba9...
> 
> TBR=cjgrant@chromium.org,vollick@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=None
> 
> Review-Url: https://codereview.chromium.org/2972843002
> Cr-Commit-Position: refs/heads/master@{#484300}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a4774...

TBR=cjgrant@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
==========

[Ian Vollick, 2017-07-07 17:29:59]

Description was changed from

==========
Reland of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #1 id:1 of https://codereview.chromium.org/2972843002/ )

Reason for revert:
I am not able to reproduce the errors locally. Will try and
fix this FYI bot offline.

Original issue's description:
> Revert of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #2 id:20001 of https://codereview.chromium.org/2969023003/ )
> 
> Reason for revert:
> Breaks some VR browser navigation tests due to failing DCHECK
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbu...
> 
> Original issue's description:
> > [vr] Ensure that textured elements never draw with a dirty texture
> > 
> > This should never be possible, so I've made UpdateTexture a part
> > of OnBeginFrame. It will usually early out (because the texture won't
> > be dirty), but will ensure that we never again draw with a dirty
> > texture. I've also added a DCHECK to ensure that we don't change this.
> > 
> > NB: this has no impact on the the update throttling done by the URL
> > bar since it has its own overridden implementation of OnBeginFrame.
> > 
> > BUG=None
> > 
> > Review-Url: https://codereview.chromium.org/2969023003
> > Cr-Commit-Position: refs/heads/master@{#484142}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba9...
> 
> TBR=cjgrant@chromium.org,vollick@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=None
> 
> Review-Url: https://codereview.chromium.org/2972843002
> Cr-Commit-Position: refs/heads/master@{#484300}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a4774...

TBR=cjgrant@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
==========

to

==========
Reland of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #1 id:1 of https://codereview.chromium.org/2972843002/ )

Reason for revert:
Reverting this CL did fix errors on the FYI bot, but I cannot reproduce
them on ToT. New fixes / issues may have been introduced. Since this
is blocking progress, I'm going to resubmit and try and find a
reproduction offline.

Original issue's description:
> Revert of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #2 id:20001 of https://codereview.chromium.org/2969023003/ )
> 
> Reason for revert:
> Breaks some VR browser navigation tests due to failing DCHECK
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbu...
> 
> Original issue's description:
> > [vr] Ensure that textured elements never draw with a dirty texture
> > 
> > This should never be possible, so I've made UpdateTexture a part
> > of OnBeginFrame. It will usually early out (because the texture won't
> > be dirty), but will ensure that we never again draw with a dirty
> > texture. I've also added a DCHECK to ensure that we don't change this.
> > 
> > NB: this has no impact on the the update throttling done by the URL
> > bar since it has its own overridden implementation of OnBeginFrame.
> > 
> > BUG=None
> > 
> > Review-Url: https://codereview.chromium.org/2969023003
> > Cr-Commit-Position: refs/heads/master@{#484142}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba9...
> 
> TBR=cjgrant@chromium.org,vollick@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=None
> 
> Review-Url: https://codereview.chromium.org/2972843002
> Cr-Commit-Position: refs/heads/master@{#484300}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a4774...

TBR=cjgrant@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
==========

[Ian Vollick, 2017-07-07 17:30:03]

The CQ bit was checked by vollick@chromium.org

[commit-bot: I haz the power, 2017-07-07 17:30:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 18:14:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499448603366520, "parent_rev":
"34c91e77bd48805a2f8e190c1de1078f29acae18", "commit_rev":
"c4d9ba2e2790ecb45344f3b3967b0d5e3af5b5c4"}

[commit-bot: I haz the power, 2017-07-07 18:14:50]

Description was changed from

==========
Reland of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #1 id:1 of https://codereview.chromium.org/2972843002/ )

Reason for revert:
Reverting this CL did fix errors on the FYI bot, but I cannot reproduce
them on ToT. New fixes / issues may have been introduced. Since this
is blocking progress, I'm going to resubmit and try and find a
reproduction offline.

Original issue's description:
> Revert of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #2 id:20001 of https://codereview.chromium.org/2969023003/ )
> 
> Reason for revert:
> Breaks some VR browser navigation tests due to failing DCHECK
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbu...
> 
> Original issue's description:
> > [vr] Ensure that textured elements never draw with a dirty texture
> > 
> > This should never be possible, so I've made UpdateTexture a part
> > of OnBeginFrame. It will usually early out (because the texture won't
> > be dirty), but will ensure that we never again draw with a dirty
> > texture. I've also added a DCHECK to ensure that we don't change this.
> > 
> > NB: this has no impact on the the update throttling done by the URL
> > bar since it has its own overridden implementation of OnBeginFrame.
> > 
> > BUG=None
> > 
> > Review-Url: https://codereview.chromium.org/2969023003
> > Cr-Commit-Position: refs/heads/master@{#484142}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba9...
> 
> TBR=cjgrant@chromium.org,vollick@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=None
> 
> Review-Url: https://codereview.chromium.org/2972843002
> Cr-Commit-Position: refs/heads/master@{#484300}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a4774...

TBR=cjgrant@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
==========

to

==========
Reland of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #1 id:1 of https://codereview.chromium.org/2972843002/ )

Reason for revert:
Reverting this CL did fix errors on the FYI bot, but I cannot reproduce
them on ToT. New fixes / issues may have been introduced. Since this
is blocking progress, I'm going to resubmit and try and find a
reproduction offline.

Original issue's description:
> Revert of [vr] Ensure that textured elements never draw with a dirty texture
(patchset #2 id:20001 of https://codereview.chromium.org/2969023003/ )
> 
> Reason for revert:
> Breaks some VR browser navigation tests due to failing DCHECK
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbu...
> 
> Original issue's description:
> > [vr] Ensure that textured elements never draw with a dirty texture
> > 
> > This should never be possible, so I've made UpdateTexture a part
> > of OnBeginFrame. It will usually early out (because the texture won't
> > be dirty), but will ensure that we never again draw with a dirty
> > texture. I've also added a DCHECK to ensure that we don't change this.
> > 
> > NB: this has no impact on the the update throttling done by the URL
> > bar since it has its own overridden implementation of OnBeginFrame.
> > 
> > BUG=None
> > 
> > Review-Url: https://codereview.chromium.org/2969023003
> > Cr-Commit-Position: refs/heads/master@{#484142}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba9...
> 
> TBR=cjgrant@chromium.org,vollick@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=None
> 
> Review-Url: https://codereview.chromium.org/2972843002
> Cr-Commit-Position: refs/heads/master@{#484300}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a4774...

TBR=cjgrant@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None

Review-Url: https://codereview.chromium.org/2965413002
Cr-Commit-Position: refs/heads/master@{#484985}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4d9ba2e2790ecb45344f3b3967b...
==========

[commit-bot: I haz the power, 2017-07-07 18:14:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4d9ba2e2790ecb45344f3b3967b...