DescriptionRevert of [vr] Ensure that textured elements never draw with a dirty texture (patchset #2 id:20001 of https://codereview.chromium.org/2969023003/ )
Reason for revert:
Breaks some VR browser navigation tests due to failing DCHECK https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbuilds=200
Original issue's description:
> [vr] Ensure that textured elements never draw with a dirty texture
>
> This should never be possible, so I've made UpdateTexture a part
> of OnBeginFrame. It will usually early out (because the texture won't
> be dirty), but will ensure that we never again draw with a dirty
> texture. I've also added a DCHECK to ensure that we don't change this.
>
> NB: this has no impact on the the update throttling done by the URL
> bar since it has its own overridden implementation of OnBeginFrame.
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2969023003
> Cr-Commit-Position: refs/heads/master@{#484142}
> Committed: https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba933e0c3dc2405
TBR=cjgrant@chromium.org,vollick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review-Url: https://codereview.chromium.org/2972843002
Cr-Commit-Position: refs/heads/master@{#484300}
Committed: https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a477411d93a42c58e
Patch Set 1 #
Messages
Total messages: 14 (6 generated)
|