Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2972843002: Revert of [vr] Ensure that textured elements never draw with a dirty texture (Closed)

Created:
3 years, 5 months ago by bsheedy
Modified:
3 years, 5 months ago
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [vr] Ensure that textured elements never draw with a dirty texture (patchset #2 id:20001 of https://codereview.chromium.org/2969023003/ ) Reason for revert: Breaks some VR browser navigation tests due to failing DCHECK https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbuilds=200 Original issue's description: > [vr] Ensure that textured elements never draw with a dirty texture > > This should never be possible, so I've made UpdateTexture a part > of OnBeginFrame. It will usually early out (because the texture won't > be dirty), but will ensure that we never again draw with a dirty > texture. I've also added a DCHECK to ensure that we don't change this. > > NB: this has no impact on the the update throttling done by the URL > bar since it has its own overridden implementation of OnBeginFrame. > > BUG=None > > Review-Url: https://codereview.chromium.org/2969023003 > Cr-Commit-Position: refs/heads/master@{#484142} > Committed: https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba933e0c3dc2405 TBR=cjgrant@chromium.org,vollick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2972843002 Cr-Commit-Position: refs/heads/master@{#484300} Committed: https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a477411d93a42c58e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/android/vr_shell/ui_elements/textured_element.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/textured_element.cc View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
bsheedy
Created Revert of [vr] Ensure that textured elements never draw with a dirty texture
3 years, 5 months ago (2017-07-05 17:29:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972843002/1
3 years, 5 months ago (2017-07-05 17:30:00 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-05 17:30:02 UTC) #5
mthiesse
lgtm
3 years, 5 months ago (2017-07-05 17:34:31 UTC) #7
bsheedy
+mthiesse since he seems to be available ATM
3 years, 5 months ago (2017-07-05 17:34:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972843002/1
3 years, 5 months ago (2017-07-05 17:35:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a477411d93a42c58e
3 years, 5 months ago (2017-07-05 17:36:22 UTC) #13
Ian Vollick
3 years, 5 months ago (2017-07-07 17:25:16 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2965413002/ by vollick@chromium.org.

The reason for reverting is: These failures seem to persist on ToT..

Powered by Google App Engine
This is Rietveld 408576698