[vr] Ensure that textured elements never draw with a dirty texture

[vr] Ensure that textured elements never draw with a dirty texture

This should never be possible, so I've made UpdateTexture a part
of OnBeginFrame. It will usually early out (because the texture won't
be dirty), but will ensure that we never again draw with a dirty
texture. I've also added a DCHECK to ensure that we don't change this.

NB: this has no impact on the the update throttling done by the URL
bar since it has its own overridden implementation of OnBeginFrame.

BUG=None

Review-Url: https://codereview.chromium.org/2969023003
Cr-Commit-Position: refs/heads/master@{#484142}
Committed: https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba933e0c3dc2405

[Ian Vollick, 2017-07-04 16:25:10]

vollick@chromium.org changed reviewers:
+ cjgrant@chromium.org

[cjgrant, 2017-07-04 16:29:16]

https://codereview.chromium.org/2969023003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_elements/textured_element.cc (right):

https://codereview.chromium.org/2969023003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_elements/textured_element.cc:32: if
(!initialized_ || !GetTexture()->dirty())
Now that we call this on every frame, I think we should be checking visibility
here as well (ie. through IsVisible()).  Otherwise, we may be updating the
texture when an invisible element changes state.  Eg. transient URL bar gets
updates while invisible, but should not redraw.

[Ian Vollick, 2017-07-04 16:40:53]

https://codereview.chromium.org/2969023003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_elements/textured_element.cc (right):

https://codereview.chromium.org/2969023003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_elements/textured_element.cc:32: if
(!initialized_ || !GetTexture()->dirty())
On 2017/07/04 16:29:16, cjgrant wrote:
> Now that we call this on every frame, I think we should be checking visibility
> here as well (ie. through IsVisible()).  Otherwise, we may be updating the
> texture when an invisible element changes state.  Eg. transient URL bar gets
> updates while invisible, but should not redraw.

Good call. Done.

[cjgrant, 2017-07-04 17:52:16]

lgtm

[Ian Vollick, 2017-07-04 17:55:54]

The CQ bit was checked by vollick@chromium.org

[commit-bot: I haz the power, 2017-07-04 17:56:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 19:00:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499190954986580,
"parent_rev": "668e108d975f27413dbf9487ec51ed78da6f0ed4", "commit_rev":
"286a6b8e56a7bd0b7ac58d8b9ba933e0c3dc2405"}

[commit-bot: I haz the power, 2017-07-04 19:01:14]

Description was changed from

==========
[vr] Ensure that textured elements never draw with a dirty texture

This should never be possible, so I've made UpdateTexture a part
of OnBeginFrame. It will usually early out (because the texture won't
be dirty), but will ensure that we never again draw with a dirty
texture. I've also added a DCHECK to ensure that we don't change this.

NB: this has no impact on the the update throttling done by the URL
bar since it has its own overridden implementation of OnBeginFrame.

BUG=None
==========

to

==========
[vr] Ensure that textured elements never draw with a dirty texture

This should never be possible, so I've made UpdateTexture a part
of OnBeginFrame. It will usually early out (because the texture won't
be dirty), but will ensure that we never again draw with a dirty
texture. I've also added a DCHECK to ensure that we don't change this.

NB: this has no impact on the the update throttling done by the URL
bar since it has its own overridden implementation of OnBeginFrame.

BUG=None

Review-Url: https://codereview.chromium.org/2969023003
Cr-Commit-Position: refs/heads/master@{#484142}
Committed:
https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba9...
==========

[commit-bot: I haz the power, 2017-07-04 19:01:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba9...

[bsheedy, 2017-07-05 17:29:42]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2972843002/ by bsheedy@chromium.org.

The reason for reverting is: Breaks some VR browser navigation tests due to
failing DCHECK
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbu....