Avoid "using namespace blink" in global scope

Avoid "using namespace blink" in global scope

With jumbo (unity builds, merged translation units) a "using blink" 
statement intended for just the local translation unit will affect
many other translation units which causes various issues.

There is also (with jumbo) a warning about such usage that will prevent
things from compiling.

Without this patch this file will have to be manually excluded from
jumbo builds and I am trying to avoid such exclusion lists for
performance and maintenance.

Review-Url: https://codereview.chromium.org/2965323002
Cr-Commit-Position: refs/heads/master@{#487501}
Committed: https://chromium.googlesource.com/chromium/src/+/d460c016ba94c5921c85ca6f7c8af2cd106a9188

[Daniel Bratell, 2017-07-07 09:13:17]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 09:13:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 09:28:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 09:28:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Daniel Bratell, 2017-07-07 12:07:50]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 12:08:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-07-07 12:30:22]

Description was changed from

==========
Trying to avoid a jumbo exlude for mac.
==========

to

==========
Avoid "using namespace blink" in global scope

With jumbo (unity builds, merged translation units) a "using blink" 
statement intended for just the local translation unit will affect
many other translation units which causes various issues.

There is also (with jumbo) a warning about such usage that will prevent
things from compiling.

Without this patch this patch will have to be manually excluded from
jumbo builds and I am trying to avoid such exclusion lists for
performance and maintenance.
==========

[Daniel Bratell, 2017-07-07 12:31:51]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 12:31:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-07-07 12:33:10]

bratell@opera.com changed reviewers:
+ ojan@chromium.org

[Daniel Bratell, 2017-07-07 12:33:10]

ojan, can you please take a look?

It's a cleanup patch for jumbo, to remove a hardcoded exclusion of this file.

[commit-bot: I haz the power, 2017-07-07 14:31:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 14:31:54]

Dry run: This issue passed the CQ dry run.

[Daniel Bratell, 2017-07-11 16:00:08]

bratell@opera.com changed reviewers:
+ yosin@chromium.org

[Daniel Bratell, 2017-07-11 16:00:09]

yusin, do you think this is a reasonable way to solve this?

The problem is the block at the start of the file that is not inside namespace
blink {}.

[chromium-reviews, 2017-07-14 03:54:38]

Can we move these static functions into "namespace blink" with anonymous
namespace?
Note: getBaselinePoint() doesn't have "static", but it used only in
WebSubstringUtil.mm

2017年7月12日(水) 1:00 <bratell@opera.com>:

> yusin, do you think this is a reasonable way to solve this?
>
> The problem is the block at the start of the file that is not inside
> namespace
> blink {}.
>
> https://codereview.chromium.org/2965323002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blink-reviews, 2017-07-14 03:54:38]

Can we move these static functions into "namespace blink" with anonymous
namespace?
Note: getBaselinePoint() doesn't have "static", but it used only in
WebSubstringUtil.mm

2017年7月12日(水) 1:00 <bratell@opera.com>:

> yusin, do you think this is a reasonable way to solve this?
>
> The problem is the block at the start of the file that is not inside
> namespace
> blink {}.
>
> https://codereview.chromium.org/2965323002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Daniel Bratell, 2017-07-14 10:05:55]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-14 10:05:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-07-14 10:06:50]

On 2017/07/14 03:54:38, blink-reviews wrote:
> Can we move these static functions into "namespace blink" with anonymous
> namespace?
> Note: getBaselinePoint() doesn't have "static", but it used only in
> WebSubstringUtil.mm


I will try to see what works.

[Daniel Bratell, 2017-07-14 10:08:21]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-14 10:08:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-07-14 10:08:51]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-14 10:08:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 11:51:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 11:51:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Daniel Bratell, 2017-07-14 15:32:35]

Seems to work.
yosin, is this what you planned?

[yosin_UTC9, 2017-07-18 01:58:58]

lgtm

Yes, this is what I suggested.

[Daniel Bratell, 2017-07-18 11:19:45]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2017-07-18 11:19:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-07-18 11:20:14]

Description was changed from

==========
Avoid "using namespace blink" in global scope

With jumbo (unity builds, merged translation units) a "using blink" 
statement intended for just the local translation unit will affect
many other translation units which causes various issues.

There is also (with jumbo) a warning about such usage that will prevent
things from compiling.

Without this patch this patch will have to be manually excluded from
jumbo builds and I am trying to avoid such exclusion lists for
performance and maintenance.
==========

to

==========
Avoid "using namespace blink" in global scope

With jumbo (unity builds, merged translation units) a "using blink" 
statement intended for just the local translation unit will affect
many other translation units which causes various issues.

There is also (with jumbo) a warning about such usage that will prevent
things from compiling.

Without this patch this file will have to be manually excluded from
jumbo builds and I am trying to avoid such exclusion lists for
performance and maintenance.
==========

[commit-bot: I haz the power, 2017-07-18 13:27:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-18 13:27:41]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Daniel Bratell, 2017-07-18 14:43:07]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2017-07-18 14:43:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-18 16:44:21]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1500388987537930,
"parent_rev": "6a100c0fd7c17e82cf6c44e15a35087411949453", "commit_rev":
"d460c016ba94c5921c85ca6f7c8af2cd106a9188"}

[commit-bot: I haz the power, 2017-07-18 16:44:33]

Description was changed from

==========
Avoid "using namespace blink" in global scope

With jumbo (unity builds, merged translation units) a "using blink" 
statement intended for just the local translation unit will affect
many other translation units which causes various issues.

There is also (with jumbo) a warning about such usage that will prevent
things from compiling.

Without this patch this file will have to be manually excluded from
jumbo builds and I am trying to avoid such exclusion lists for
performance and maintenance.
==========

to

==========
Avoid "using namespace blink" in global scope

With jumbo (unity builds, merged translation units) a "using blink" 
statement intended for just the local translation unit will affect
many other translation units which causes various issues.

There is also (with jumbo) a warning about such usage that will prevent
things from compiling.

Without this patch this file will have to be manually excluded from
jumbo builds and I am trying to avoid such exclusion lists for
performance and maintenance.

Review-Url: https://codereview.chromium.org/2965323002
Cr-Commit-Position: refs/heads/master@{#487501}
Committed:
https://chromium.googlesource.com/chromium/src/+/d460c016ba94c5921c85ca6f7c8a...
==========

[commit-bot: I haz the power, 2017-07-18 16:44:34]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d460c016ba94c5921c85ca6f7c8a...