third_party/WebKit/Source/core/editing/BUILD.gn - Issue 2965323002: Avoid "using namespace blink" in global scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/BUILD.gn

Issue 2965323002: Avoid "using namespace blink" in global scope (Closed)

Patch Set: Use anonymous namespaces Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/BUILD.gn

diff --git a/third_party/WebKit/Source/core/editing/BUILD.gn b/third_party/WebKit/Source/core/editing/BUILD.gn

index f4a148991b3cae53e3f70e0b8e5739c84ca65993..629367372f8a5a3c82344eb86ef116bcc1446ac0 100644

--- a/third_party/WebKit/Source/core/editing/BUILD.gn

+++ b/third_party/WebKit/Source/core/editing/BUILD.gn

@@ -287,13 +287,6 @@ blink_core_sources("editing") {

sources += [ "commands/SmartReplaceCF.cpp" ]

}

- if (is_mac) {

- jumbo_excluded_sources = [

- # Using "using blink" in global scope.

- "WebSubstringUtil.mm",

- ]

- }

configs += [

# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

"//build/config/compiler:no_size_t_to_int_warning",

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/WebSubstringUtil.mm » ('j') | no next file with comments »