Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: third_party/WebKit/Source/core/editing/BUILD.gn

Issue 2965323002: Avoid "using namespace blink" in global scope (Closed)
Patch Set: Use anonymous namespaces Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/WebSubstringUtil.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/WebKit/Source/core/core.gni") 5 import("//third_party/WebKit/Source/core/core.gni")
6 6
7 blink_core_sources("editing") { 7 blink_core_sources("editing") {
8 split_count = 5 8 split_count = 5
9 sources = [ 9 sources = [
10 "CaretDisplayItemClient.cpp", 10 "CaretDisplayItemClient.cpp",
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 "state_machines/StateMachineUtil.cpp", 280 "state_machines/StateMachineUtil.cpp",
281 "state_machines/StateMachineUtil.h", 281 "state_machines/StateMachineUtil.h",
282 "state_machines/TextSegmentationMachineState.cpp", 282 "state_machines/TextSegmentationMachineState.cpp",
283 "state_machines/TextSegmentationMachineState.h", 283 "state_machines/TextSegmentationMachineState.h",
284 ] 284 ]
285 285
286 if (is_mac) { 286 if (is_mac) {
287 sources += [ "commands/SmartReplaceCF.cpp" ] 287 sources += [ "commands/SmartReplaceCF.cpp" ]
288 } 288 }
289 289
290 if (is_mac) {
291 jumbo_excluded_sources = [
292 # Using "using blink" in global scope.
293 "WebSubstringUtil.mm",
294 ]
295 }
296
297 configs += [ 290 configs += [
298 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 291 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
299 "//build/config/compiler:no_size_t_to_int_warning", 292 "//build/config/compiler:no_size_t_to_int_warning",
300 ] 293 ]
301 } 294 }
302 295
303 source_set("unit_tests") { 296 source_set("unit_tests") {
304 testonly = true 297 testonly = true
305 sources = [ 298 sources = [
306 "CompositionUnderlineTest.cpp", 299 "CompositionUnderlineTest.cpp",
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 "//third_party/WebKit/Source:config", 369 "//third_party/WebKit/Source:config",
377 "//third_party/WebKit/Source:inside_blink", 370 "//third_party/WebKit/Source:inside_blink",
378 ] 371 ]
379 372
380 deps = [ 373 deps = [
381 "//testing/gmock", 374 "//testing/gmock",
382 "//testing/gtest", 375 "//testing/gtest",
383 "//third_party/WebKit/Source/core:core", 376 "//third_party/WebKit/Source/core:core",
384 ] 377 ]
385 } 378 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/WebSubstringUtil.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698