Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2964893002: Make VisibleSelection::AppendTrailingWhitespace() as const function (Closed)

Created:
3 years, 5 months ago by yosin_UTC9
Modified:
3 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make VisibleSelection::AppendTrailingWhitespace() as const function This patch makes |VisibleSelection::AppendTrailingWhitespace()| as const function to make |VisibleSelection| as *virtual* immutable for improving code health. BUG=660320 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2964893002 Cr-Commit-Position: refs/heads/master@{#484066} Committed: https://chromium.googlesource.com/chromium/src/+/fb62cb3fb002c372baa6093f5432e97d5ee3ba30

Patch Set 1 : 2017-07-04T15:32:18 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 2 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL As suggested in https://codereview.chromium.org/2964863003#msg6
3 years, 5 months ago (2017-07-04 07:16:25 UTC) #6
yoichio
lgtm cool!
3 years, 5 months ago (2017-07-04 08:06:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964893002/1
3 years, 5 months ago (2017-07-04 08:10:44 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 08:29:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb62cb3fb002c372baa6093f5432...

Powered by Google App Engine
This is Rietveld 408576698