third_party/WebKit/Source/core/editing/SelectionController.cpp - Issue 2964893002: Make VisibleSelection::AppendTrailingWhitespace() as const function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2964893002: Make VisibleSelection::AppendTrailingWhitespace() as const function (Closed)

Patch Set: 2017-07-04T15:32:18 Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionController.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp

index 79d43e54169fab9189a6e3e5fd59249023152792..249f063c71d6b466d748f6c0e12c0fd7555eef8c 100644

--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp

@@ -529,7 +529,7 @@ bool SelectionController::SelectClosestWordFromHitTestResult(

}

if (append_trailing_whitespace == AppendTrailingWhitespace::kShouldAppend)

- new_selection.AppendTrailingWhitespace();

+ new_selection = new_selection.AppendTrailingWhitespace();

return UpdateSelectionForMouseDownDispatchingSelectStart(

inner_node,

@@ -573,7 +573,7 @@ void SelectionController::SelectClosestMisspellingFromHitTestResult(

SelectionInFlatTree::Builder().Collapse(start).Extend(end).Build());

if (append_trailing_whitespace == AppendTrailingWhitespace::kShouldAppend)

- new_selection.AppendTrailingWhitespace();

+ new_selection = new_selection.AppendTrailingWhitespace();

UpdateSelectionForMouseDownDispatchingSelectStart(

inner_node,

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleSelection.h » ('j') | no next file with comments »