Refactor SelectionController::SelectClosestWordFromHitTestResult()

Refactor SelectionController::SelectClosestWordFromHitTestResult()

This patch changes |SelectionController::SelectClosestWordFromHitTestResult()|
to use const variable for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2964863003
Cr-Commit-Position: refs/heads/master@{#484176}
Committed: https://chromium.googlesource.com/chromium/src/+/574d9b1862565cd77123de42537b27faef0f9bc0

[yosin_UTC9, 2017-07-04 04:07:19]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 04:07:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-07-04 05:20:34]

Description was changed from

==========
2017-07-04T13:06:21

BUG=

2017-07-04T13:06:17
==========

to

==========
Refactor SelectionController::SelectClosestWordFromHitTestResult()

This patch changes |SelectionController::SelectClosestWordFromHitTestResult()|
to limit scope of variable for improving readability.

Note: Since |new_selection| is modified with |AppendTrailingWhitespace()|
laster,
we can't use const variable.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-07-04 05:20:45]

yosin@chromium.org changed reviewers:
+ yoichio@chromium.org

[yosin_UTC9, 2017-07-04 05:20:45]

PTAL

[yoichio, 2017-07-04 05:32:18]

https://codereview.chromium.org/2964863003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionController.cpp (right):

https://codereview.chromium.org/2964863003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionController.cpp:531:
new_selection.AppendTrailingWhitespace();
How about making AppendTrailingWhitespace() const and return VS like
 javascript string functions?

[commit-bot: I haz the power, 2017-07-04 06:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 06:22:07]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-07-04 09:45:17]

Description was changed from

==========
Refactor SelectionController::SelectClosestWordFromHitTestResult()

This patch changes |SelectionController::SelectClosestWordFromHitTestResult()|
to limit scope of variable for improving readability.

Note: Since |new_selection| is modified with |AppendTrailingWhitespace()|
laster,
we can't use const variable.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Refactor SelectionController::SelectClosestWordFromHitTestResult()

This patch changes |SelectionController::SelectClosestWordFromHitTestResult()|
to use const variable for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-07-04 09:48:31]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 09:48:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-07-04 09:49:38]

PTAL

Utilize const variable since VisibleSelection::AppendTrailingWhitespace() is
changed to
const function.

[commit-bot: I haz the power, 2017-07-04 12:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 12:08:11]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-07-05 01:43:42]

lgtm

[yosin_UTC9, 2017-07-05 01:53:01]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-07-05 01:53:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 01:57:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499219581126200,
"parent_rev": "029734fda5d49ccebc8fd64f1e4ff1bab1db1fe6", "commit_rev":
"574d9b1862565cd77123de42537b27faef0f9bc0"}

[commit-bot: I haz the power, 2017-07-05 01:57:39]

Description was changed from

==========
Refactor SelectionController::SelectClosestWordFromHitTestResult()

This patch changes |SelectionController::SelectClosestWordFromHitTestResult()|
to use const variable for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Refactor SelectionController::SelectClosestWordFromHitTestResult()

This patch changes |SelectionController::SelectClosestWordFromHitTestResult()|
to use const variable for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2964863003
Cr-Commit-Position: refs/heads/master@{#484176}
Committed:
https://chromium.googlesource.com/chromium/src/+/574d9b1862565cd77123de42537b...
==========

[commit-bot: I haz the power, 2017-07-05 01:57:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/574d9b1862565cd77123de42537b...