Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: content/renderer/media/media_stream_video_source_unittest.cc

Issue 2964003002: Remove support for old getUserMedia video constraints algorithm. (Closed)
Patch Set: rebase and address hbos@ comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_video_source_unittest.cc
diff --git a/content/renderer/media/media_stream_video_source_unittest.cc b/content/renderer/media/media_stream_video_source_unittest.cc
index 3da29505d4fa7ba9c47b3fed1681bbb7811d766f..b1a9c3ce413258c1cd5cd7682af58a8cbc1b5466 100644
--- a/content/renderer/media/media_stream_video_source_unittest.cc
+++ b/content/renderer/media/media_stream_video_source_unittest.cc
@@ -9,11 +9,9 @@
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
-#include "base/test/scoped_feature_list.h"
#include "base/test/scoped_task_environment.h"
#include "build/build_config.h"
#include "content/child/child_process.h"
-#include "content/public/common/content_features.h"
#include "content/renderer/media/media_stream_video_source.h"
#include "content/renderer/media/media_stream_video_track.h"
#include "content/renderer/media/mock_constraint_factory.h"
@@ -50,9 +48,6 @@ class MediaStreamVideoSourceTest : public ::testing::Test {
1000.0,
media::PIXEL_FORMAT_I420),
false)) {
- scoped_feature_list_.InitAndDisableFeature(
- features::kMediaStreamOldVideoConstraints);
-
media::VideoCaptureFormats formats;
formats.push_back(media::VideoCaptureFormat(gfx::Size(1280, 720), 30,
media::PIXEL_FORMAT_I420));
@@ -105,7 +100,6 @@ class MediaStreamVideoSourceTest : public ::testing::Test {
int height,
double frame_rate,
bool detect_rotation = false) {
- DCHECK(!IsOldVideoConstraints());
blink::WebMediaStreamTrack track =
CreateTrack("123",
VideoTrackAdapterSettings(
@@ -141,7 +135,6 @@ class MediaStreamVideoSourceTest : public ::testing::Test {
int capture_height,
int expected_width,
int expected_height) {
- DCHECK(!IsOldVideoConstraints());
// Configure the track to crop to the expected resolution.
blink::WebMediaStreamTrack track =
CreateTrackAndStartSource(expected_width, expected_height, 30.0);
@@ -268,7 +261,6 @@ class MediaStreamVideoSourceTest : public ::testing::Test {
blink::WebMediaStreamSource webkit_source_;
// |mock_source_| is owned by |webkit_source_|.
MockMediaStreamVideoSource* mock_source_;
- base::test::ScopedFeatureList scoped_feature_list_;
};
TEST_F(MediaStreamVideoSourceTest, AddTrackAndStartSource) {
@@ -418,850 +410,4 @@ TEST_F(MediaStreamVideoSourceTest, MutedSource) {
sink.DisconnectFromTrack();
}
-class MediaStreamVideoSourceOldConstraintsTest : public ::testing::Test {
- public:
- MediaStreamVideoSourceOldConstraintsTest()
- : scoped_task_environment_(
- base::test::ScopedTaskEnvironment::MainThreadType::UI),
- child_process_(new ChildProcess()),
- number_of_successful_constraints_applied_(0),
- number_of_failed_constraints_applied_(0),
- result_(MEDIA_DEVICE_OK),
- result_name_(""),
- mock_source_(new MockMediaStreamVideoSource(true)) {
- scoped_feature_list_.InitAndEnableFeature(
- features::kMediaStreamOldVideoConstraints);
-
- media::VideoCaptureFormats formats;
- formats.push_back(media::VideoCaptureFormat(
- gfx::Size(1280, 720), 30, media::PIXEL_FORMAT_I420));
- formats.push_back(media::VideoCaptureFormat(
- gfx::Size(640, 480), 30, media::PIXEL_FORMAT_I420));
- formats.push_back(media::VideoCaptureFormat(
- gfx::Size(352, 288), 30, media::PIXEL_FORMAT_I420));
- formats.push_back(media::VideoCaptureFormat(
- gfx::Size(320, 240), 30, media::PIXEL_FORMAT_I420));
- mock_source_->SetSupportedFormats(formats);
- webkit_source_.Initialize(blink::WebString::FromASCII("dummy_source_id"),
- blink::WebMediaStreamSource::kTypeVideo,
- blink::WebString::FromASCII("dummy_source_name"),
- false /* remote */);
- webkit_source_.SetExtraData(mock_source_);
- }
-
- void TearDown() override {
- webkit_source_.Reset();
- blink::WebHeap::CollectAllGarbageForTesting();
- }
-
- protected:
- // Create a track that's associated with |webkit_source_|.
- blink::WebMediaStreamTrack CreateTrack(
- const std::string& id,
- const blink::WebMediaConstraints& constraints) {
- bool enabled = true;
- return MediaStreamVideoTrack::CreateVideoTrack(
- mock_source_, constraints,
- base::Bind(
- &MediaStreamVideoSourceOldConstraintsTest::OnConstraintsApplied,
- base::Unretained(this)),
- enabled);
- }
-
- blink::WebMediaStreamTrack CreateTrackAndStartSource(
- const blink::WebMediaConstraints& constraints,
- int expected_width,
- int expected_height,
- int expected_frame_rate) {
- DCHECK(IsOldVideoConstraints());
- blink::WebMediaStreamTrack track = CreateTrack("123", constraints);
-
- mock_source_->CompleteGetSupportedFormats();
- const media::VideoCaptureFormat& format = mock_source()->start_format();
- EXPECT_EQ(expected_width, format.frame_size.width());
- EXPECT_EQ(expected_height, format.frame_size.height());
- EXPECT_EQ(expected_frame_rate, format.frame_rate);
-
- EXPECT_EQ(0, NumberOfSuccessConstraintsCallbacks());
- mock_source_->StartMockedSource();
- // Once the source has started successfully we expect that the
- // ConstraintsCallback in MediaStreamSource::AddTrack completes.
- EXPECT_EQ(1, NumberOfSuccessConstraintsCallbacks());
- return track;
- }
-
- int NumberOfSuccessConstraintsCallbacks() const {
- return number_of_successful_constraints_applied_;
- }
-
- int NumberOfFailedConstraintsCallbacks() const {
- return number_of_failed_constraints_applied_;
- }
-
- content::MediaStreamRequestResult error_type() const { return result_; }
- blink::WebString error_name() const { return result_name_; }
-
- MockMediaStreamVideoSource* mock_source() { return mock_source_; }
-
- const blink::WebMediaStreamSource& webkit_source() { return webkit_source_; }
-
- // Test that the source crops/scales to the requested width and
- // height even though the camera delivers a larger frame.
- void TestSourceCropFrame(int capture_width,
- int capture_height,
- const blink::WebMediaConstraints& constraints,
- int expected_width,
- int expected_height) {
- DCHECK(IsOldVideoConstraints());
- // Expect the source to start capture with the supported resolution.
- blink::WebMediaStreamTrack track = CreateTrackAndStartSource(
- constraints, capture_width, capture_height, 30);
-
- MockMediaStreamVideoSink sink;
- sink.ConnectToTrack(track);
- DeliverVideoFrameAndWaitForRenderer(capture_width, capture_height, &sink);
- EXPECT_EQ(1, sink.number_of_frames());
-
- // Expect the delivered frame to be cropped.
- EXPECT_EQ(expected_height, sink.frame_size().height());
- EXPECT_EQ(expected_width, sink.frame_size().width());
- sink.DisconnectFromTrack();
- }
-
- void DeliverVideoFrameAndWaitForRenderer(int width, int height,
- MockMediaStreamVideoSink* sink) {
- base::RunLoop run_loop;
- base::Closure quit_closure = run_loop.QuitClosure();
- EXPECT_CALL(*sink, OnVideoFrame()).WillOnce(
- RunClosure(quit_closure));
- scoped_refptr<media::VideoFrame> frame =
- media::VideoFrame::CreateBlackFrame(gfx::Size(width, height));
- mock_source()->DeliverVideoFrame(frame);
- run_loop.Run();
- }
-
- void DeliverVideoFrameAndWaitForTwoRenderers(
- int width,
- int height,
- MockMediaStreamVideoSink* sink1,
- MockMediaStreamVideoSink* sink2) {
- base::RunLoop run_loop;
- base::Closure quit_closure = run_loop.QuitClosure();
- EXPECT_CALL(*sink1, OnVideoFrame());
- EXPECT_CALL(*sink2, OnVideoFrame()).WillOnce(
- RunClosure(quit_closure));
- scoped_refptr<media::VideoFrame> frame =
- media::VideoFrame::CreateBlackFrame(gfx::Size(width, height));
- mock_source()->DeliverVideoFrame(frame);
- run_loop.Run();
- }
-
- void TestTwoTracksWithDifferentConstraints(
- const blink::WebMediaConstraints& constraints1,
- const blink::WebMediaConstraints& constraints2,
- int capture_width,
- int capture_height,
- int expected_width1,
- int expected_height1,
- int expected_width2,
- int expected_height2) {
- blink::WebMediaStreamTrack track1 =
- CreateTrackAndStartSource(constraints1, capture_width, capture_height,
- MediaStreamVideoSource::kDefaultFrameRate);
-
- blink::WebMediaStreamTrack track2 = CreateTrack("dummy", constraints2);
-
- MockMediaStreamVideoSink sink1;
- sink1.ConnectToTrack(track1);
- EXPECT_EQ(0, sink1.number_of_frames());
-
- MockMediaStreamVideoSink sink2;
- sink2.ConnectToTrack(track2);
- EXPECT_EQ(0, sink2.number_of_frames());
-
- DeliverVideoFrameAndWaitForTwoRenderers(capture_width,
- capture_height,
- &sink1,
- &sink2);
-
- EXPECT_EQ(1, sink1.number_of_frames());
- EXPECT_EQ(expected_width1, sink1.frame_size().width());
- EXPECT_EQ(expected_height1, sink1.frame_size().height());
-
- EXPECT_EQ(1, sink2.number_of_frames());
- EXPECT_EQ(expected_width2, sink2.frame_size().width());
- EXPECT_EQ(expected_height2, sink2.frame_size().height());
-
- sink1.DisconnectFromTrack();
- sink2.DisconnectFromTrack();
- }
-
- void SetSourceSupportedFormats(const media::VideoCaptureFormats& formats) {
- mock_source_->SetSupportedFormats(formats);
- }
-
- void ReleaseTrackAndSourceOnAddTrackCallback(
- const blink::WebMediaStreamTrack& track_to_release) {
- track_to_release_ = track_to_release;
- }
-
- private:
- void OnConstraintsApplied(MediaStreamSource* source,
- MediaStreamRequestResult result,
- const blink::WebString& result_name) {
- ASSERT_EQ(source, webkit_source().GetExtraData());
-
- if (result == MEDIA_DEVICE_OK) {
- ++number_of_successful_constraints_applied_;
- } else {
- result_ = result;
- result_name_ = result_name;
- ++number_of_failed_constraints_applied_;
- }
-
- if (!track_to_release_.IsNull()) {
- mock_source_ = nullptr;
- webkit_source_.Reset();
- track_to_release_.Reset();
- }
- }
- const base::test::ScopedTaskEnvironment scoped_task_environment_;
- const std::unique_ptr<ChildProcess> child_process_;
- blink::WebMediaStreamTrack track_to_release_;
- int number_of_successful_constraints_applied_;
- int number_of_failed_constraints_applied_;
- content::MediaStreamRequestResult result_;
- blink::WebString result_name_;
- blink::WebMediaStreamSource webkit_source_;
- // |mock_source_| is owned by |webkit_source_|.
- MockMediaStreamVideoSource* mock_source_;
- base::test::ScopedFeatureList scoped_feature_list_;
-};
-
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, AddTrackAndStartSource) {
- blink::WebMediaConstraints constraints;
- constraints.Initialize();
- blink::WebMediaStreamTrack track = CreateTrack("123", constraints);
- mock_source()->CompleteGetSupportedFormats();
- mock_source()->StartMockedSource();
- EXPECT_EQ(1, NumberOfSuccessConstraintsCallbacks());
-}
-
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- AddTwoTracksBeforeSourceStarts) {
- blink::WebMediaConstraints constraints;
- constraints.Initialize();
- blink::WebMediaStreamTrack track1 = CreateTrack("123", constraints);
- mock_source()->CompleteGetSupportedFormats();
- blink::WebMediaStreamTrack track2 = CreateTrack("123", constraints);
- EXPECT_EQ(0, NumberOfSuccessConstraintsCallbacks());
- mock_source()->StartMockedSource();
- EXPECT_EQ(2, NumberOfSuccessConstraintsCallbacks());
-}
-
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, AddTrackAfterSourceStarts) {
- blink::WebMediaConstraints constraints;
- constraints.Initialize();
- blink::WebMediaStreamTrack track1 = CreateTrack("123", constraints);
- mock_source()->CompleteGetSupportedFormats();
- mock_source()->StartMockedSource();
- EXPECT_EQ(1, NumberOfSuccessConstraintsCallbacks());
- blink::WebMediaStreamTrack track2 = CreateTrack("123", constraints);
- EXPECT_EQ(2, NumberOfSuccessConstraintsCallbacks());
-}
-
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, AddTrackAndFailToStartSource) {
- blink::WebMediaConstraints constraints;
- constraints.Initialize();
- blink::WebMediaStreamTrack track = CreateTrack("123", constraints);
- mock_source()->CompleteGetSupportedFormats();
- mock_source()->FailToStartMockedSource();
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- AddTwoTracksBeforeGetSupportedFormats) {
- blink::WebMediaConstraints constraints;
- constraints.Initialize();
- blink::WebMediaStreamTrack track1 = CreateTrack("123", constraints);
- blink::WebMediaStreamTrack track2 = CreateTrack("123", constraints);
- mock_source()->CompleteGetSupportedFormats();
- mock_source()->StartMockedSource();
- EXPECT_EQ(2, NumberOfSuccessConstraintsCallbacks());
-}
-
-// Test that the capture output is CIF if we set max constraints to CIF.
-// and the capture device support CIF.
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, MandatoryConstraintCif5Fps) {
- MockConstraintFactory factory;
- factory.basic().width.SetMax(352);
- factory.basic().height.SetMax(288);
- factory.basic().frame_rate.SetMax(5.0);
-
- CreateTrackAndStartSource(factory.CreateWebMediaConstraints(), 352, 288, 5);
-}
-
-// Test that the capture output is 720P if the camera support it and the
-// optional constraint is set to 720P.
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, MandatoryMinVgaOptional720P) {
- MockConstraintFactory factory;
- factory.basic().width.SetMin(640);
- factory.basic().height.SetMin(480);
- factory.AddAdvanced().width.SetMin(1280);
- factory.AddAdvanced().aspect_ratio.SetMin(1280.0 / 720);
-
- CreateTrackAndStartSource(factory.CreateWebMediaConstraints(), 1280, 720, 30);
-}
-
-// Test that the capture output is 720P if the camera supports it and the
-// mandatory constraint is exactly width 1280.
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, MandatoryExact720P) {
- MockConstraintFactory factory;
- factory.basic().width.SetExact(1280);
- CreateTrackAndStartSource(factory.CreateWebMediaConstraints(), 1280, 720, 30);
-}
-
-// Test that the capture output have aspect ratio 4:3 if a mandatory constraint
-// require it even if an optional constraint request a higher resolution
-// that don't have this aspect ratio.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, MandatoryAspectRatio4To3) {
- MockConstraintFactory factory;
- factory.basic().width.SetMin(640);
- factory.basic().height.SetMin(480);
- factory.basic().aspect_ratio.SetMax(640.0 / 480);
- factory.AddAdvanced().width.SetMin(1280);
-
- TestSourceCropFrame(1280, 720, factory.CreateWebMediaConstraints(), 960, 720);
-}
-
-// Test that AddTrack succeeds if the mandatory min aspect ratio it set to 2.
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, MandatoryAspectRatio2) {
- MockConstraintFactory factory;
- factory.basic().aspect_ratio.SetMin(2.0);
-
- TestSourceCropFrame(MediaStreamVideoSource::kDefaultWidth,
- MediaStreamVideoSource::kDefaultHeight,
- factory.CreateWebMediaConstraints(), 640, 320);
-}
-
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- MinAspectRatioLargerThanMaxAspectRatio) {
- MockConstraintFactory factory;
- factory.basic().aspect_ratio.SetMin(2.0);
- factory.basic().aspect_ratio.SetMax(1.0);
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- mock_source()->CompleteGetSupportedFormats();
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, MinWidthLargerThanMaxWidth) {
- MockConstraintFactory factory;
- factory.basic().width.SetMin(640);
- factory.basic().width.SetMax(320);
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- mock_source()->CompleteGetSupportedFormats();
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, MinHeightLargerThanMaxHeight) {
- MockConstraintFactory factory;
- factory.basic().height.SetMin(480);
- factory.basic().height.SetMax(360);
-
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- mock_source()->CompleteGetSupportedFormats();
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- MinFrameRateLargerThanMaxFrameRate) {
- MockConstraintFactory factory;
- factory.basic().frame_rate.SetMin(25);
- factory.basic().frame_rate.SetMax(15);
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- mock_source()->CompleteGetSupportedFormats();
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, ExactWidthNotSupported) {
- MockConstraintFactory factory;
- factory.basic().width.SetExact(12000);
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- mock_source()->CompleteGetSupportedFormats();
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, MinWidthNotSupported) {
- MockConstraintFactory factory;
- factory.basic().width.SetMin(12000);
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- mock_source()->CompleteGetSupportedFormats();
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
-// Test that its safe to release the last reference of a blink track and the
-// source during the callback if adding a track succeeds.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- ReleaseTrackAndSourceOnSuccessCallBack) {
- MockConstraintFactory factory;
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- ReleaseTrackAndSourceOnAddTrackCallback(track);
- mock_source()->CompleteGetSupportedFormats();
- mock_source()->StartMockedSource();
- EXPECT_EQ(1, NumberOfSuccessConstraintsCallbacks());
-}
-
-// Test that its safe to release the last reference of a blink track and the
-// source during the callback if adding a track fails.
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- ReleaseTrackAndSourceOnFailureCallBack) {
- MockConstraintFactory factory;
- factory.basic().width.SetMin(99999);
- {
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- ReleaseTrackAndSourceOnAddTrackCallback(track);
- }
- mock_source()->CompleteGetSupportedFormats();
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
-// Test that the source ignores an optional aspect ratio that is higher than
-// supported.
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, OptionalAspectRatioTooHigh) {
- MockConstraintFactory factory;
- factory.AddAdvanced().aspect_ratio.SetMin(2.0);
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- mock_source()->CompleteGetSupportedFormats();
-
- const media::VideoCaptureFormat& format = mock_source()->start_format();
- const double aspect_ratio = static_cast<double>(format.frame_size.width()) /
- format.frame_size.height();
- EXPECT_LT(aspect_ratio, 2);
-}
-
-// Test that the source starts video with the default resolution if the
-// that is the only supported.
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, DefaultCapability) {
- media::VideoCaptureFormats formats;
- formats.push_back(media::VideoCaptureFormat(
- gfx::Size(MediaStreamVideoSource::kDefaultWidth,
- MediaStreamVideoSource::kDefaultHeight),
- MediaStreamVideoSource::kDefaultFrameRate, media::PIXEL_FORMAT_I420));
- mock_source()->SetSupportedFormats(formats);
-
- blink::WebMediaConstraints constraints;
- constraints.Initialize();
- CreateTrackAndStartSource(constraints, MediaStreamVideoSource::kDefaultWidth,
- MediaStreamVideoSource::kDefaultHeight, 30);
-}
-
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, InvalidMandatoryConstraint) {
- MockConstraintFactory factory;
- // Use a constraint that is only known for audio.
- factory.basic().echo_cancellation.SetExact(true);
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- mock_source()->CompleteGetSupportedFormats();
- EXPECT_EQ(MEDIA_DEVICE_CONSTRAINT_NOT_SATISFIED, error_type());
- EXPECT_EQ("echoCancellation", error_name());
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
-// Test that the source ignores an unknown optional constraint.
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, InvalidOptionalConstraint) {
- MockConstraintFactory factory;
- factory.AddAdvanced().echo_cancellation.SetExact(true);
-
- CreateTrackAndStartSource(factory.CreateWebMediaConstraints(),
- MediaStreamVideoSource::kDefaultWidth,
- MediaStreamVideoSource::kDefaultHeight, 30);
-}
-
-// Tests that the source starts video with the max width and height set by
-// constraints for screencast.
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- ScreencastResolutionWithConstraint) {
- media::VideoCaptureFormats formats;
- formats.push_back(media::VideoCaptureFormat(gfx::Size(480, 270), 30,
- media::PIXEL_FORMAT_I420));
- mock_source()->SetSupportedFormats(formats);
- MockConstraintFactory factory;
- factory.basic().width.SetMax(480);
- factory.basic().height.SetMax(270);
-
- blink::WebMediaStreamTrack track = CreateTrackAndStartSource(
- factory.CreateWebMediaConstraints(), 480, 270, 30);
- EXPECT_EQ(480, mock_source()->max_requested_height());
- EXPECT_EQ(270, mock_source()->max_requested_width());
-}
-
-// Test that optional constraints are applied in order.
-// Does not apply with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, OptionalConstraints) {
- MockConstraintFactory factory;
- // Min width of 2056 pixels can not be fulfilled.
- factory.AddAdvanced().width.SetMin(2056);
- factory.AddAdvanced().width.SetMin(641);
- // Since min width is set to 641 pixels, max width 640 can not be fulfilled.
- factory.AddAdvanced().width.SetMax(640);
- CreateTrackAndStartSource(factory.CreateWebMediaConstraints(), 1280, 720, 30);
-}
-
-// Test that the source crops to the requested max width and
-// height even though the camera delivers a larger frame.
-// Redundant with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- DeliverCroppedVideoFrameOptional640360) {
- MockConstraintFactory factory;
- factory.AddAdvanced().width.SetMax(640);
- factory.AddAdvanced().height.SetMax(360);
- TestSourceCropFrame(640, 480, factory.CreateWebMediaConstraints(), 640, 360);
-}
-
-// Redundant with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- DeliverCroppedVideoFrameMandatory640360) {
- MockConstraintFactory factory;
- factory.basic().width.SetMax(640);
- factory.basic().height.SetMax(360);
- TestSourceCropFrame(640, 480, factory.CreateWebMediaConstraints(), 640, 360);
-}
-
-// Redundant with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- DeliverCroppedVideoFrameMandatory732489) {
- MockConstraintFactory factory;
- factory.basic().width.SetMax(732);
- factory.basic().height.SetMax(489);
- factory.basic().width.SetMin(732);
- factory.basic().height.SetMin(489);
- TestSourceCropFrame(1280, 720, factory.CreateWebMediaConstraints(), 732, 489);
-}
-
-// Test that the source crops to the requested max width and
-// height even though the requested frame has odd size.
-// Redundant with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- DeliverCroppedVideoFrame637359) {
- MockConstraintFactory factory;
- factory.AddAdvanced().width.SetMax(637);
- factory.AddAdvanced().height.SetMax(359);
- TestSourceCropFrame(640, 480, factory.CreateWebMediaConstraints(), 637, 359);
-}
-
-// Redundant with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- DeliverCroppedVideoFrame320320) {
- MockConstraintFactory factory;
- factory.basic().width.SetMax(320);
- factory.basic().height.SetMax(320);
- factory.basic().height.SetMin(320);
- factory.basic().width.SetMax(320);
- TestSourceCropFrame(640, 480, factory.CreateWebMediaConstraints(), 320, 320);
-}
-
-// Redundant with spec-compliant constraints.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- DeliverSmallerSizeWhenTooLargeMax) {
- MockConstraintFactory factory;
- factory.AddAdvanced().width.SetMax(1920);
- factory.AddAdvanced().height.SetMax(1080);
- factory.AddAdvanced().width.SetMin(1280);
- factory.AddAdvanced().height.SetMin(720);
- TestSourceCropFrame(1280, 720, factory.CreateWebMediaConstraints(), 1280,
- 720);
-}
-
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, TwoTracksWithVGAAndWVGA) {
- MockConstraintFactory factory1;
- factory1.AddAdvanced().width.SetMax(640);
- factory1.AddAdvanced().height.SetMax(480);
-
- MockConstraintFactory factory2;
- factory2.AddAdvanced().height.SetMax(360);
-
- TestTwoTracksWithDifferentConstraints(factory1.CreateWebMediaConstraints(),
- factory2.CreateWebMediaConstraints(),
- 640, 480, 640, 480, 640, 360);
-}
-
-// Redundant with spec-compliant constraints
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, TwoTracksWith720AndWVGA) {
- MockConstraintFactory factory1;
- factory1.AddAdvanced().width.SetMin(1280);
- factory1.AddAdvanced().height.SetMin(720);
-
- MockConstraintFactory factory2;
- factory2.basic().width.SetMax(640);
- factory2.basic().height.SetMax(360);
-
- TestTwoTracksWithDifferentConstraints(factory1.CreateWebMediaConstraints(),
- factory2.CreateWebMediaConstraints(),
- 1280, 720, 1280, 720, 640, 360);
-}
-
-// Redundant with spec-compliant constraints
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, TwoTracksWith720AndW700H700) {
- MockConstraintFactory factory1;
- factory1.AddAdvanced().width.SetMin(1280);
- factory1.AddAdvanced().height.SetMin(720);
-
- MockConstraintFactory factory2;
- factory2.basic().width.SetMax(700);
- factory2.basic().height.SetMax(700);
-
- TestTwoTracksWithDifferentConstraints(factory1.CreateWebMediaConstraints(),
- factory2.CreateWebMediaConstraints(),
- 1280, 720, 1280, 720, 700, 700);
-}
-
-// Redundant with spec-compliant constraints
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- TwoTracksWith720AndMaxAspectRatio4To3) {
- MockConstraintFactory factory1;
- factory1.AddAdvanced().width.SetMin(1280);
- factory1.AddAdvanced().height.SetMin(720);
-
- MockConstraintFactory factory2;
- factory2.basic().aspect_ratio.SetMax(640.0 / 480);
-
- TestTwoTracksWithDifferentConstraints(factory1.CreateWebMediaConstraints(),
- factory2.CreateWebMediaConstraints(),
- 1280, 720, 1280, 720, 960, 720);
-}
-
-// Redundant with spec-compliant constraints
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- TwoTracksWithVgaAndMinAspectRatio) {
- MockConstraintFactory factory1;
- factory1.AddAdvanced().width.SetMax(640);
- factory1.AddAdvanced().height.SetMax(480);
-
- MockConstraintFactory factory2;
- factory2.basic().aspect_ratio.SetMin(640.0 / 360);
-
- TestTwoTracksWithDifferentConstraints(factory1.CreateWebMediaConstraints(),
- factory2.CreateWebMediaConstraints(),
- 640, 480, 640, 480, 640, 360);
-}
-
-// Does not apply with spec-compliant constraints
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- TwoTracksWithSecondTrackFrameRateHigherThanFirst) {
- MockConstraintFactory factory1;
- factory1.basic().frame_rate.SetMin(15);
- factory1.basic().frame_rate.SetMax(15);
-
- blink::WebMediaStreamTrack track1 =
- CreateTrackAndStartSource(factory1.CreateWebMediaConstraints(),
- MediaStreamVideoSource::kDefaultWidth,
- MediaStreamVideoSource::kDefaultHeight, 15);
-
- MockConstraintFactory factory2;
- factory2.basic().frame_rate.SetMin(30);
- blink::WebMediaStreamTrack track2 =
- CreateTrack("123", factory2.CreateWebMediaConstraints());
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
-// Test that a source can change the frame resolution on the fly and that
-// tracks sinks get the new frame size unless constraints force the frame to be
-// cropped.
-// TODO(guidou): Remove this test. http://crbug.com/706408
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, SourceChangeFrameSize) {
- MockConstraintFactory factory;
- factory.AddAdvanced().width.SetMax(800);
- factory.AddAdvanced().height.SetMax(700);
-
- // Expect the source to start capture with the supported resolution.
- // Disable frame-rate adjustment in spec-compliant mode to ensure no frames
- // are dropped.
- blink::WebMediaStreamTrack track = CreateTrackAndStartSource(
- factory.CreateWebMediaConstraints(), 640, 480, 30);
-
- MockMediaStreamVideoSink sink;
- sink.ConnectToTrack(track);
- EXPECT_EQ(0, sink.number_of_frames());
- DeliverVideoFrameAndWaitForRenderer(320, 240, &sink);
- EXPECT_EQ(1, sink.number_of_frames());
- // Expect the delivered frame to be passed unchanged since its smaller than
- // max requested.
- EXPECT_EQ(320, sink.frame_size().width());
- EXPECT_EQ(240, sink.frame_size().height());
-
- DeliverVideoFrameAndWaitForRenderer(640, 480, &sink);
- EXPECT_EQ(2, sink.number_of_frames());
- // Expect the delivered frame to be passed unchanged since its smaller than
- // max requested.
- EXPECT_EQ(640, sink.frame_size().width());
- EXPECT_EQ(480, sink.frame_size().height());
-
- DeliverVideoFrameAndWaitForRenderer(1280, 720, &sink);
- EXPECT_EQ(3, sink.number_of_frames());
- // Expect a frame to be cropped since its larger than max requested.
- EXPECT_EQ(800, sink.frame_size().width());
- EXPECT_EQ(700, sink.frame_size().height());
-
- sink.DisconnectFromTrack();
-}
-
-// Test that the constraint negotiation can handle 0.0 fps as frame rate.
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, Use0FpsSupportedFormat) {
- media::VideoCaptureFormats formats;
- formats.push_back(media::VideoCaptureFormat(gfx::Size(640, 480), 0.0f,
- media::PIXEL_FORMAT_I420));
- formats.push_back(media::VideoCaptureFormat(gfx::Size(320, 240), 0.0f,
- media::PIXEL_FORMAT_I420));
- mock_source()->SetSupportedFormats(formats);
-
- blink::WebMediaConstraints constraints;
- constraints.Initialize();
- blink::WebMediaStreamTrack track = CreateTrack("123", constraints);
- mock_source()->CompleteGetSupportedFormats();
- mock_source()->StartMockedSource();
- EXPECT_EQ(1, NumberOfSuccessConstraintsCallbacks());
-
- MockMediaStreamVideoSink sink;
- sink.ConnectToTrack(track);
- EXPECT_EQ(0, sink.number_of_frames());
- DeliverVideoFrameAndWaitForRenderer(320, 240, &sink);
- EXPECT_EQ(1, sink.number_of_frames());
- // Expect the delivered frame to be passed unchanged since its smaller than
- // max requested.
- EXPECT_EQ(320, sink.frame_size().width());
- EXPECT_EQ(240, sink.frame_size().height());
- sink.DisconnectFromTrack();
-}
-
-// Test that a source producing no frames change the source ReadyState to muted.
-// that in a reasonable time frame the muted state turns to false.
-TEST_F(MediaStreamVideoSourceOldConstraintsTest, MutedSource) {
- // Setup the source for support a frame rate of 999 fps in order to test
- // the muted event faster. This is since the frame monitoring uses
- // PostDelayedTask that is dependent on the source frame rate.
- // Note that media::limits::kMaxFramesPerSecond is 1000.
- media::VideoCaptureFormats formats;
- formats.push_back(media::VideoCaptureFormat(
- gfx::Size(640, 480), media::limits::kMaxFramesPerSecond - 1,
- media::PIXEL_FORMAT_I420));
- SetSourceSupportedFormats(formats);
-
- MockConstraintFactory factory;
- blink::WebMediaStreamTrack track =
- CreateTrackAndStartSource(factory.CreateWebMediaConstraints(), 640, 480,
- media::limits::kMaxFramesPerSecond - 1);
-
- MockMediaStreamVideoSink sink;
- sink.ConnectToTrack(track);
- EXPECT_EQ(track.Source().GetReadyState(),
- blink::WebMediaStreamSource::kReadyStateLive);
-
- base::RunLoop run_loop;
- base::Closure quit_closure = run_loop.QuitClosure();
- bool muted_state = false;
- EXPECT_CALL(*mock_source(), DoSetMutedState(_))
- .WillOnce(DoAll(SaveArg<0>(&muted_state), RunClosure(quit_closure)));
- run_loop.Run();
- EXPECT_EQ(muted_state, true);
-
- EXPECT_EQ(track.Source().GetReadyState(),
- blink::WebMediaStreamSource::kReadyStateMuted);
-
- base::RunLoop run_loop2;
- base::Closure quit_closure2 = run_loop2.QuitClosure();
- EXPECT_CALL(*mock_source(), DoSetMutedState(_))
- .WillOnce(DoAll(SaveArg<0>(&muted_state), RunClosure(quit_closure2)));
- DeliverVideoFrameAndWaitForRenderer(640, 480, &sink);
- run_loop2.Run();
-
- EXPECT_EQ(muted_state, false);
- EXPECT_EQ(track.Source().GetReadyState(),
- blink::WebMediaStreamSource::kReadyStateLive);
-
- sink.DisconnectFromTrack();
-}
-
-// Test that an optional constraint with an invalid aspect ratio is ignored.
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- InvalidOptionalAspectRatioIgnored) {
- MockConstraintFactory factory;
- factory.AddAdvanced().aspect_ratio.SetMax(0.0);
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- mock_source()->CompleteGetSupportedFormats();
- EXPECT_EQ(0, NumberOfFailedConstraintsCallbacks());
-}
-
-// Test that setting an invalid mandatory aspect ratio fails.
-// Does not apply with spec-compliant constraints.
-TEST_F(MediaStreamVideoSourceOldConstraintsTest,
- InvalidMandatoryAspectRatioFails) {
- MockConstraintFactory factory;
- factory.basic().aspect_ratio.SetMax(0.0);
- blink::WebMediaStreamTrack track =
- CreateTrack("123", factory.CreateWebMediaConstraints());
- mock_source()->CompleteGetSupportedFormats();
- EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
-}
-
} // namespace content
« no previous file with comments | « content/renderer/media/media_stream_video_source.cc ('k') | content/renderer/media/media_stream_video_track.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698