Log basic/advanced tab action from java

Log basic/advanced tab action from java

Instead of logging the tab of a deletion from the BrowsingDataBridge,
it should be logged in Java because the C++ code is also used from a few
other places and the action would be recorded incorrectly.

BUG=681523
Review-Url: https://codereview.chromium.org/2963973002
Cr-Commit-Position: refs/heads/master@{#483676}
Committed: https://chromium.googlesource.com/chromium/src/+/72ce5d481f11212f8cbb99f13058a82f4f4a0d84

[dullweber, 2017-06-29 12:24:13]

Description was changed from

==========
Log basic/advanced tab action from java

Instead of logging the tab of a deletion from the BrowsingDataBridge,
it should be logged in Java because the C++ code is also used from a few
other places and the action would be recorded incorrectly.

BUG=2962523003
==========

to

==========
Log basic/advanced tab action from java

Instead of logging the tab of a deletion from the BrowsingDataBridge,
it should be logged in Java because the C++ code is also used from a few
other places and the action would be recorded incorrectly.

BUG=681523
==========

[dullweber, 2017-06-29 12:40:53]

dullweber@chromium.org changed reviewers:
+ bauerb@chromium.org

[dullweber, 2017-06-29 12:40:53]

Hi, 
I noticed that user actions added in this Cl (http://crrev.com/2927063002) were
recorded when other code used the BrowsingDataBridge too, so I moved them closer
to the actual event. Please take a look

[Bernhard Bauer, 2017-06-29 17:13:18]

https://codereview.chromium.org/2963973002/diff/1/components/browsing_data/co...
File components/browsing_data/core/browsing_data_utils.cc (left):

https://codereview.chromium.org/2963973002/diff/1/components/browsing_data/co...
components/browsing_data/core/browsing_data_utils.cc:95:
UMA_HISTOGRAM_ENUMERATION("History.ClearBrowsingData.UserDeletedFromTab", tab,
Is this histogram now unused? In that case you should probably mark it as
obsolete.

[dullweber, 2017-06-30 08:48:06]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 08:48:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-06-30 08:48:35]

https://codereview.chromium.org/2963973002/diff/1/components/browsing_data/co...
File components/browsing_data/core/browsing_data_utils.cc (left):

https://codereview.chromium.org/2963973002/diff/1/components/browsing_data/co...
components/browsing_data/core/browsing_data_utils.cc:95:
UMA_HISTOGRAM_ENUMERATION("History.ClearBrowsingData.UserDeletedFromTab", tab,
On 2017/06/29 17:13:18, Bernhard Bauer wrote:
> Is this histogram now unused? In that case you should probably mark it as
> obsolete.

Thanks for noticing this. I forgot to add the histogram again.

[commit-bot: I haz the power, 2017-06-30 09:50:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 09:50:17]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-06-30 10:38:48]

lgtm

[dullweber, 2017-06-30 11:14:56]

The CQ bit was checked by dullweber@chromium.org

[commit-bot: I haz the power, 2017-06-30 11:15:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 11:20:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498821296005820,
"parent_rev": "7c9f0094c6c0c202aa8d7219b89a5909edd74f1b", "commit_rev":
"72ce5d481f11212f8cbb99f13058a82f4f4a0d84"}

[commit-bot: I haz the power, 2017-06-30 11:20:15]

Description was changed from

==========
Log basic/advanced tab action from java

Instead of logging the tab of a deletion from the BrowsingDataBridge,
it should be logged in Java because the C++ code is also used from a few
other places and the action would be recorded incorrectly.

BUG=681523
==========

to

==========
Log basic/advanced tab action from java

Instead of logging the tab of a deletion from the BrowsingDataBridge,
it should be logged in Java because the C++ code is also used from a few
other places and the action would be recorded incorrectly.

BUG=681523

Review-Url: https://codereview.chromium.org/2963973002
Cr-Commit-Position: refs/heads/master@{#483676}
Committed:
https://chromium.googlesource.com/chromium/src/+/72ce5d481f11212f8cbb99f13058...
==========

[commit-bot: I haz the power, 2017-06-30 11:20:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/72ce5d481f11212f8cbb99f13058...