Log basic/advanced tab action from java

components/browsing_data/core/browsing_data_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/browsing_data/core/browsing_data_utils.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/user_metrics.h"
 #include "components/browsing_data/core/counters/autofill_counter.h"
 #include "components/browsing_data/core/counters/history_counter.h"
@@ skipping 73 matching lines @@
       base::RecordAction(base::UserMetricsAction(
           "ClearBrowsingData_TimePeriodChanged_LastMonth"));
       break;
     case TimePeriod::ALL_TIME:
       base::RecordAction(base::UserMetricsAction(
           "ClearBrowsingData_TimePeriodChanged_Everything"));
       break;
   }
 }
 
-void RecordDeletionFromTab(ClearBrowsingDataTab tab) {
-  UMA_HISTOGRAM_ENUMERATION("History.ClearBrowsingData.UserDeletedFromTab", tab,

[Bernhard Bauer, 2017/06/29 17:13:18]

Is this histogram now unused? In that case you should probably mark it as
obsolete.

[dullweber, 2017/06/30 08:48:35]

Thanks for noticing this. I forgot to add the histogram again.

-                            browsing_data::ClearBrowsingDataTab::NUM_TYPES);
-  switch (tab) {
-    case ClearBrowsingDataTab::BASIC:
-      base::RecordAction(base::UserMetricsAction("ClearBrowsingData_BasicTab"));
-      break;
-    case ClearBrowsingDataTab::ADVANCED:
-      base::RecordAction(
-          base::UserMetricsAction("ClearBrowsingData_AdvancedTab"));
-      break;
-    case ClearBrowsingDataTab::NUM_TYPES:
-      NOTREACHED();
-  }
-}
-
 base::string16 GetCounterTextFromResult(
     const BrowsingDataCounter::Result* result) {
   base::string16 text;
   std::string pref_name = result->source()->GetPrefName();
 
   if (!result->Finished()) {
     // The counter is still counting.
     text = l10n_util::GetStringUTF16(IDS_CLEAR_BROWSING_DATA_CALCULATING);
 
   } else if (pref_name == prefs::kDeletePasswords) {
@@ skipping 173 matching lines @@
                       prefs->GetBoolean(prefs::kDeleteCache));
     prefs->SetBoolean(prefs::kDeleteCookiesBasic,
                       prefs->GetBoolean(prefs::kDeleteCookies));
     prefs->SetInteger(prefs::kDeleteTimePeriodBasic,
                       prefs->GetInteger(prefs::kDeleteTimePeriod));
     prefs->SetBoolean(prefs::kPreferencesMigratedToBasic, true);
   }
 }
 
 }  // namespace browsing_data