Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3628)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

Issue 2963973002: Log basic/advanced tab action from java (Closed)
Patch Set: Add histogram Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesAdvanced.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
index 1b4964b4d4063363b215720c087a597d0d5c4e01..abcd8fb0eae15644b972d532ae9673c9d27d7a57 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
@@ -305,6 +305,11 @@ public class ClearBrowsingDataPreferences extends PreferenceFragment
return selected;
}
+ /**
+ * Notify subclasses that browsing data is about to be cleared.
+ */
+ protected void onClearBrowsingData() {}
+
/**
* Requests the browsing data corresponding to the given dialog options to be deleted.
* @param options The dialog options whose corresponding data should be deleted.
@@ -312,6 +317,7 @@ public class ClearBrowsingDataPreferences extends PreferenceFragment
private final void clearBrowsingData(EnumSet<DialogOption> options,
@Nullable String[] blacklistedDomains, @Nullable int[] blacklistedDomainReasons,
@Nullable String[] ignoredDomains, @Nullable int[] ignoredDomainReasons) {
+ onClearBrowsingData();
showProgressDialog();
RecordHistogram.recordMediumTimesHistogram("History.ClearBrowsingData.TimeSpentInDialog",
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesAdvanced.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698