Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2963783003: Revert of Update SCT serialization format in Expect-CT reports (Closed)

Created:
3 years, 5 months ago by engedy
Modified:
3 years, 5 months ago
Reviewers:
mattm, estark
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri, net-reviews_chromium.org, martijn+crwatch_martijnc.be
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update SCT serialization format in Expect-CT reports (patchset #3 id:180001 of https://codereview.chromium.org/2960183003/ ) Reason for revert: Compile failure on Win builder. Original issue's description: > Reland of Update SCT serialization format in Expect-CT reports (patchset #1 id:1 of https://codereview.chromium.org/2960163002/ ) > > Reason for revert: > Fixing buffer overflow in test code > > Original issue's description: > > Revert of Update SCT serialization format in Expect-CT reports (patchset #3 id:40001 of https://codereview.chromium.org/2959593002/ ) > > > > Reason for revert: > > Heap-buffer-overflow on Chromium OS ASAN builders during ChromeExpectCTReporterTest.SendReport. > > > > Please see comments on revert CL for more detail. > > > > Original issue's description: > > > Update SCT serialization and other format details in Expect-CT reports > > > > > > This adds a net::ct::EncodeSignedCertificateTimestamp function alongside the > > > existing CT serialization functions, and uses it to properly encode SCTs in > > > Expect-CT reports. > > > > > > The relevant spec change is > > > https://github.com/httpwg/http-extensions/commit/20c5cfd5ef5b630e142b3251ecafc004ad8f2092, > > > though it hasn't made it into a published draft yet. Before, we were including a > > > JSON object containing a subset of information from the SCT based on the source of > > > the SCT, but that was deemed unnecessary and now the spec just says to include a > > > standard serialization of the SCT. > > > > > > The other report format changes made to bring the implementation in line with the > > > spec are: > > > - Shortening the 'origin' string values > > > - Wrapping the report in a JSON dictionary with a single 'expect-ct-report' key > > > > > > BUG=679012 > > > > > > Review-Url: https://codereview.chromium.org/2959593002 > > > Cr-Commit-Position: refs/heads/master@{#482905} > > > Committed: https://chromium.googlesource.com/chromium/src/+/19bd384f656790e8e409086b5b97a53b3a6f5921 > > > > TBR=mattm@chromium.org,estark@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=679012 > > > > Review-Url: https://codereview.chromium.org/2960163002 > > Cr-Commit-Position: refs/heads/master@{#482924} > > Committed: https://chromium.googlesource.com/chromium/src/+/8af690d4cd89e0e402d08ce8e4f078acf862a317 > > TBR=mattm@chromium.org,engedy@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=679012 > > Review-Url: https://codereview.chromium.org/2960183003 > Cr-Commit-Position: refs/heads/master@{#483070} > Committed: https://chromium.googlesource.com/chromium/src/+/03b29e1fbf80c616d6aaff6201ee8771f4df986b TBR=mattm@chromium.org,estark@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=679012 Review-Url: https://codereview.chromium.org/2963783003 Cr-Commit-Position: refs/heads/master@{#483090} Committed: https://chromium.googlesource.com/chromium/src/+/3817bb935917d0215bab904c063c47cbe3db3142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -155 lines) Patch
M chrome/browser/ssl/chrome_expect_ct_reporter.cc View 3 chunks +77 lines, -46 lines 0 comments Download
M chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc View 5 chunks +115 lines, -76 lines 0 comments Download
M net/cert/ct_serialization.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/cert/ct_serialization.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/cert/ct_serialization_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
engedy
Created Revert of Update SCT serialization format in Expect-CT reports
3 years, 5 months ago (2017-06-28 19:05:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963783003/1
3 years, 5 months ago (2017-06-28 19:06:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3817bb935917d0215bab904c063c47cbe3db3142
3 years, 5 months ago (2017-06-28 19:07:22 UTC) #7
estark
3 years, 5 months ago (2017-06-28 20:02:30 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2957063005/ by estark@chromium.org.

The reason for reverting is: Broke the build on Windows, need to fix.

Powered by Google App Engine
This is Rietveld 408576698