Revert of Update SCT serialization format in Expect-CT reports

Revert of Update SCT serialization format in Expect-CT reports (patchset #3 id:40001 of https://codereview.chromium.org/2959593002/ )

Reason for revert:
Heap-buffer-overflow on Chromium OS ASAN builders during ChromeExpectCTReporterTest.SendReport.

Please see comments on revert CL for more detail.

Original issue's description:
> Update SCT serialization and other format details in Expect-CT reports
> 
> This adds a net::ct::EncodeSignedCertificateTimestamp function alongside the
> existing CT serialization functions, and uses it to properly encode SCTs in
> Expect-CT reports.
> 
> The relevant spec change is
> https://github.com/httpwg/http-extensions/commit/20c5cfd5ef5b630e142b3251ecafc004ad8f2092,
> though it hasn't made it into a published draft yet. Before, we were including a
> JSON object containing a subset of information from the SCT based on the source of
> the SCT, but that was deemed unnecessary and now the spec just says to include a
> standard serialization of the SCT.
> 
> The other report format changes made to bring the implementation in line with the
> spec are:
> - Shortening the 'origin' string values
> - Wrapping the report in a JSON dictionary with a single 'expect-ct-report' key
> 
> BUG=679012
> 
> Review-Url: https://codereview.chromium.org/2959593002
> Cr-Commit-Position: refs/heads/master@{#482905}
> Committed: https://chromium.googlesource.com/chromium/src/+/19bd384f656790e8e409086b5b97a53b3a6f5921

TBR=mattm@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679012
Review-Url: https://codereview.chromium.org/2960163002
Cr-Commit-Position: refs/heads/master@{#482924}
Committed: https://chromium.googlesource.com/chromium/src/+/8af690d4cd89e0e402d08ce8e4f078acf862a317

[engedy, 2017-06-28 09:22:20]

The CQ bit was checked by engedy@chromium.org

[engedy, 2017-06-28 09:22:22]

Created Revert of Update SCT serialization format in Expect-CT reports

[commit-bot: I haz the power, 2017-06-28 09:22:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[engedy, 2017-06-28 09:22:53]

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_...

READ of size 32 at 0x6040001a1338 thread T0
    #0 0xaf6372 in __interceptor_memcpy
(/b/s/w/ir/out/Release/unit_tests+0xaf6372)
    #1 0x7f883014630b in std::char_traits<char>::copy(char*, char const*,
unsigned long)
/build/gcc-4.8-mW1ufQ/gcc-4.8-4.8.4/build/x86_64-linux-gnu/libstdc++-v3/include/bits/char_traits.h:271
    #2 0x7f8830146e8d in _Y_ZNSs7_M_copyEPcPKcm
/build/gcc-4.8-mW1ufQ/gcc-4.8-4.8.4/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.h:359
    #3 0x7f88301b99f8 in std::string::append(char const*, unsigned long)
/build/gcc-4.8-mW1ufQ/gcc-4.8-4.8.4/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:316
    #4 0x10877c8d in AppendToStringT<std::basic_string<char> >
base/strings/string_piece.cc:76:13
    #5 0x10877c8d in
base::internal::AppendToString(base::BasicStringPiece<std::string> const&,
std::string*) base/strings/string_piece.cc:80
    #6 0xe74e5d4 in AppendToString base/strings/string_piece.h:278:5
    #7 0xe74e5d4 in WriteEncodedBytes net/cert/ct_serialization.cc:220
    #8 0xe74e5d4 in
net::ct::EncodeSignedCertificateTimestamp(scoped_refptr<net::ct::SignedCertificateTimestamp>
const&, std::string*) net/cert/ct_serialization.cc:437
    #9 0x1157454e in AddSCT chrome/browser/ssl/chrome_expect_ct_reporter.cc:87:3
    #10 0x1157454e in ChromeExpectCTReporter::OnExpectCTFailed(net::HostPortPair
const&, GURL const&, base::Time, net::X509Certificate const*,
net::X509Certificate const*,
std::vector<net::SignedCertificateTimestampAndStatus,
std::allocator<net::SignedCertificateTimestampAndStatus> > const&)
chrome/browser/ssl/chrome_expect_ct_reporter.cc:164
    #11 0x205ffed in ChromeExpectCTReporterTest_SendReport_Test::TestBody()
chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:456:12
    #12 0x741f87c in HandleExceptionsInMethodIfSupported<testing::Test, void>
third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #13 0x741f87c in testing::Test::Run()
third_party/googletest/src/googletest/src/gtest.cc:2471
    #14 0x7421834 in testing::TestInfo::Run()
third_party/googletest/src/googletest/src/gtest.cc:2653:11
    #15 0x7422996 in testing::TestCase::Run()
third_party/googletest/src/googletest/src/gtest.cc:2771:28
    #16 0x7437106 in testing::internal::UnitTestImpl::RunAllTests()
third_party/googletest/src/googletest/src/gtest.cc:4648:43
    #17 0x7436679 in
HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>
third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #18 0x7436679 in testing::UnitTest::Run()
third_party/googletest/src/googletest/src/gtest.cc:4256
    #19 0xe1ad969 in RUN_ALL_TESTS
third_party/googletest/src/googletest/include/gtest/gtest.h:2237:46
    #20 0xe1ad969 in base::TestSuite::Run() base/test/test_suite.cc:271
    #21 0xe1b2bb5 in Run base/callback.h:80:12
    #22 0xe1b2bb5 in base::(anonymous
namespace)::LaunchUnitTestsInternal(base::Callback<int (),
(base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int,
bool, base::Callback<void (), (base::internal::CopyMode)1,
(base::internal::RepeatMode)1> const&)
base/test/launcher/unit_test_launcher.cc:216
    #23 0xe1b26b6 in base::LaunchUnitTests(int, char**, base::Callback<int (),
(base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)
base/test/launcher/unit_test_launcher.cc:458:10
    #24 0xe194938 in main chrome/test/base/run_all_unittests.cc:30:10
    #25 0x7f882fb25f44 in __libc_start_main
/build/eglibc-MjiXCM/eglibc-2.19/csu/libc-start.c:287

[commit-bot: I haz the power, 2017-06-28 09:22:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498641740553530, "parent_rev":
"32945390643a73501858d98fbe6fa906fdff72a7", "commit_rev":
"8af690d4cd89e0e402d08ce8e4f078acf862a317"}

[commit-bot: I haz the power, 2017-06-28 09:23:19]

Description was changed from

==========
Revert of Update SCT serialization format in Expect-CT reports (patchset #3
id:40001 of https://codereview.chromium.org/2959593002/ )

Reason for revert:
Heap-buffer-overflow on Chromium OS ASAN builders during
ChromeExpectCTReporterTest.SendReport.

Please see comments on revert CL for more detail.

Original issue's description:
> Update SCT serialization and other format details in Expect-CT reports
> 
> This adds a net::ct::EncodeSignedCertificateTimestamp function alongside the
> existing CT serialization functions, and uses it to properly encode SCTs in
> Expect-CT reports.
> 
> The relevant spec change is
>
https://github.com/httpwg/http-extensions/commit/20c5cfd5ef5b630e142b3251ecaf...,
> though it hasn't made it into a published draft yet. Before, we were including
a
> JSON object containing a subset of information from the SCT based on the
source of
> the SCT, but that was deemed unnecessary and now the spec just says to include
a
> standard serialization of the SCT.
> 
> The other report format changes made to bring the implementation in line with
the
> spec are:
> - Shortening the 'origin' string values
> - Wrapping the report in a JSON dictionary with a single 'expect-ct-report'
key
> 
> BUG=679012
> 
> Review-Url: https://codereview.chromium.org/2959593002
> Cr-Commit-Position: refs/heads/master@{#482905}
> Committed:
https://chromium.googlesource.com/chromium/src/+/19bd384f656790e8e409086b5b97...

TBR=mattm@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679012
==========

to

==========
Revert of Update SCT serialization format in Expect-CT reports (patchset #3
id:40001 of https://codereview.chromium.org/2959593002/ )

Reason for revert:
Heap-buffer-overflow on Chromium OS ASAN builders during
ChromeExpectCTReporterTest.SendReport.

Please see comments on revert CL for more detail.

Original issue's description:
> Update SCT serialization and other format details in Expect-CT reports
> 
> This adds a net::ct::EncodeSignedCertificateTimestamp function alongside the
> existing CT serialization functions, and uses it to properly encode SCTs in
> Expect-CT reports.
> 
> The relevant spec change is
>
https://github.com/httpwg/http-extensions/commit/20c5cfd5ef5b630e142b3251ecaf...,
> though it hasn't made it into a published draft yet. Before, we were including
a
> JSON object containing a subset of information from the SCT based on the
source of
> the SCT, but that was deemed unnecessary and now the spec just says to include
a
> standard serialization of the SCT.
> 
> The other report format changes made to bring the implementation in line with
the
> spec are:
> - Shortening the 'origin' string values
> - Wrapping the report in a JSON dictionary with a single 'expect-ct-report'
key
> 
> BUG=679012
> 
> Review-Url: https://codereview.chromium.org/2959593002
> Cr-Commit-Position: refs/heads/master@{#482905}
> Committed:
https://chromium.googlesource.com/chromium/src/+/19bd384f656790e8e409086b5b97...

TBR=mattm@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679012

Review-Url: https://codereview.chromium.org/2960163002
Cr-Commit-Position: refs/heads/master@{#482924}
Committed:
https://chromium.googlesource.com/chromium/src/+/8af690d4cd89e0e402d08ce8e4f0...
==========

[commit-bot: I haz the power, 2017-06-28 09:23:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8af690d4cd89e0e402d08ce8e4f0...

[estark, 2017-06-28 16:11:54]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2960183003/ by estark@chromium.org.

The reason for reverting is: Fixing buffer overflow in test code.