Reland of Update SCT serialization format in Expect-CT reports

Reland of Update SCT serialization format in Expect-CT reports (patchset #1 id:1 of https://codereview.chromium.org/2960163002/ )

Reason for revert:
Fixing buffer overflow in test code

Original issue's description:
> Revert of Update SCT serialization format in Expect-CT reports (patchset #3 id:40001 of https://codereview.chromium.org/2959593002/ )
> 
> Reason for revert:
> Heap-buffer-overflow on Chromium OS ASAN builders during ChromeExpectCTReporterTest.SendReport.
> 
> Please see comments on revert CL for more detail.
> 
> Original issue's description:
> > Update SCT serialization and other format details in Expect-CT reports
> > 
> > This adds a net::ct::EncodeSignedCertificateTimestamp function alongside the
> > existing CT serialization functions, and uses it to properly encode SCTs in
> > Expect-CT reports.
> > 
> > The relevant spec change is
> > https://github.com/httpwg/http-extensions/commit/20c5cfd5ef5b630e142b3251ecafc004ad8f2092,
> > though it hasn't made it into a published draft yet. Before, we were including a
> > JSON object containing a subset of information from the SCT based on the source of
> > the SCT, but that was deemed unnecessary and now the spec just says to include a
> > standard serialization of the SCT.
> > 
> > The other report format changes made to bring the implementation in line with the
> > spec are:
> > - Shortening the 'origin' string values
> > - Wrapping the report in a JSON dictionary with a single 'expect-ct-report' key
> > 
> > BUG=679012
> > 
> > Review-Url: https://codereview.chromium.org/2959593002
> > Cr-Commit-Position: refs/heads/master@{#482905}
> > Committed: https://chromium.googlesource.com/chromium/src/+/19bd384f656790e8e409086b5b97a53b3a6f5921
> 
> TBR=mattm@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=679012
> 
> Review-Url: https://codereview.chromium.org/2960163002
> Cr-Commit-Position: refs/heads/master@{#482924}
> Committed: https://chromium.googlesource.com/chromium/src/+/8af690d4cd89e0e402d08ce8e4f078acf862a317

TBR=mattm@chromium.org,engedy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679012
Review-Url: https://codereview.chromium.org/2960183003
Cr-Commit-Position: refs/heads/master@{#483070}
Committed: https://chromium.googlesource.com/chromium/src/+/03b29e1fbf80c616d6aaff6201ee8771f4df986b

[estark, 2017-06-28 16:11:55]

Created Reland of Update SCT serialization format in Expect-CT reports

[estark, 2017-06-28 16:12:14]

(not ready for re-review yet, I will update when it is)

[estark, 2017-06-28 16:43:26]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 16:43:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 16:43:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 16:43:41]

Dry run: This issue passed the CQ dry run.

[estark, 2017-06-28 16:44:43]

Patchset #2 (id:140001) has been deleted

[estark, 2017-06-28 16:47:49]

Matt, could you take a look at the patchset 2 <-> 3 diff? Thanks!

[mattm, 2017-06-28 18:20:00]

lgtm

[estark, 2017-06-28 18:25:45]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2017-06-28 18:26:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 18:26:49]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1498674345851000,
"parent_rev": "8d38f6b3a62d7dfee52859ff283cccc2e7effa19", "commit_rev":
"03b29e1fbf80c616d6aaff6201ee8771f4df986b"}

[commit-bot: I haz the power, 2017-06-28 18:27:06]

Description was changed from

==========
Reland of Update SCT serialization format in Expect-CT reports (patchset #1 id:1
of https://codereview.chromium.org/2960163002/ )

Reason for revert:
Fixing buffer overflow in test code

Original issue's description:
> Revert of Update SCT serialization format in Expect-CT reports (patchset #3
id:40001 of https://codereview.chromium.org/2959593002/ )
> 
> Reason for revert:
> Heap-buffer-overflow on Chromium OS ASAN builders during
ChromeExpectCTReporterTest.SendReport.
> 
> Please see comments on revert CL for more detail.
> 
> Original issue's description:
> > Update SCT serialization and other format details in Expect-CT reports
> > 
> > This adds a net::ct::EncodeSignedCertificateTimestamp function alongside the
> > existing CT serialization functions, and uses it to properly encode SCTs in
> > Expect-CT reports.
> > 
> > The relevant spec change is
> >
https://github.com/httpwg/http-extensions/commit/20c5cfd5ef5b630e142b3251ecaf...,
> > though it hasn't made it into a published draft yet. Before, we were
including a
> > JSON object containing a subset of information from the SCT based on the
source of
> > the SCT, but that was deemed unnecessary and now the spec just says to
include a
> > standard serialization of the SCT.
> > 
> > The other report format changes made to bring the implementation in line
with the
> > spec are:
> > - Shortening the 'origin' string values
> > - Wrapping the report in a JSON dictionary with a single 'expect-ct-report'
key
> > 
> > BUG=679012
> > 
> > Review-Url: https://codereview.chromium.org/2959593002
> > Cr-Commit-Position: refs/heads/master@{#482905}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/19bd384f656790e8e409086b5b97...
> 
> TBR=mattm@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=679012
> 
> Review-Url: https://codereview.chromium.org/2960163002
> Cr-Commit-Position: refs/heads/master@{#482924}
> Committed:
https://chromium.googlesource.com/chromium/src/+/8af690d4cd89e0e402d08ce8e4f0...

TBR=mattm@chromium.org,engedy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679012
==========

to

==========
Reland of Update SCT serialization format in Expect-CT reports (patchset #1 id:1
of https://codereview.chromium.org/2960163002/ )

Reason for revert:
Fixing buffer overflow in test code

Original issue's description:
> Revert of Update SCT serialization format in Expect-CT reports (patchset #3
id:40001 of https://codereview.chromium.org/2959593002/ )
> 
> Reason for revert:
> Heap-buffer-overflow on Chromium OS ASAN builders during
ChromeExpectCTReporterTest.SendReport.
> 
> Please see comments on revert CL for more detail.
> 
> Original issue's description:
> > Update SCT serialization and other format details in Expect-CT reports
> > 
> > This adds a net::ct::EncodeSignedCertificateTimestamp function alongside the
> > existing CT serialization functions, and uses it to properly encode SCTs in
> > Expect-CT reports.
> > 
> > The relevant spec change is
> >
https://github.com/httpwg/http-extensions/commit/20c5cfd5ef5b630e142b3251ecaf...,
> > though it hasn't made it into a published draft yet. Before, we were
including a
> > JSON object containing a subset of information from the SCT based on the
source of
> > the SCT, but that was deemed unnecessary and now the spec just says to
include a
> > standard serialization of the SCT.
> > 
> > The other report format changes made to bring the implementation in line
with the
> > spec are:
> > - Shortening the 'origin' string values
> > - Wrapping the report in a JSON dictionary with a single 'expect-ct-report'
key
> > 
> > BUG=679012
> > 
> > Review-Url: https://codereview.chromium.org/2959593002
> > Cr-Commit-Position: refs/heads/master@{#482905}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/19bd384f656790e8e409086b5b97...
> 
> TBR=mattm@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=679012
> 
> Review-Url: https://codereview.chromium.org/2960163002
> Cr-Commit-Position: refs/heads/master@{#482924}
> Committed:
https://chromium.googlesource.com/chromium/src/+/8af690d4cd89e0e402d08ce8e4f0...

TBR=mattm@chromium.org,engedy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679012

Review-Url: https://codereview.chromium.org/2960183003
Cr-Commit-Position: refs/heads/master@{#483070}
Committed:
https://chromium.googlesource.com/chromium/src/+/03b29e1fbf80c616d6aaff6201ee...
==========

[commit-bot: I haz the power, 2017-06-28 18:27:08]

Committed patchset #3 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/03b29e1fbf80c616d6aaff6201ee...

[estark, 2017-06-28 18:28:59]

On 2017/06/28 18:27:08, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:180001) as
>
https://chromium.googlesource.com/chromium/src/+/03b29e1fbf80c616d6aaff6201ee...

Ugh, did not mean to skip CQ for this, hopefully nothing explodes :(

[engedy, 2017-06-28 19:05:54]

A revert of this CL (patchset #3 id:180001) has been created in
https://codereview.chromium.org/2963783003/ by engedy@chromium.org.

The reason for reverting is: Compile failure on Win builder..

[estark, 2017-06-28 19:06:12]

A revert of this CL (patchset #3 id:180001) has been created in
https://codereview.chromium.org/2957363002/ by estark@chromium.org.

The reason for reverting is: Unintentionally bypassed CQ and broke the build.

[findit-for-me, 2017-06-28 19:38:00]

Findit (https://goo.gl/kROfz5) confirmed this CL at revision 483070 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...