Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2963223003: Reland of Switch Chrome on Linux to libc++ (Closed)

Created:
3 years, 5 months ago by ynovikov
Modified:
3 years, 5 months ago
Reviewers:
Tom Anderson, Devlin, Nico
CC:
chromium-reviews, Lei Zhang, michaelpg
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Switch Chrome on Linux to libc++ (patchset #1 id:1 of https://codereview.chromium.org/2965693002/ ) Reason for revert: ANGLE compilation issues should be fixed by https://chromium-review.googlesource.com/557679 Original issue's description: > Revert of Switch Chrome on Linux to libc++ (patchset #5 id:180001 of https://codereview.chromium.org/2933573002/ ) > > Reason for revert: > Breaks https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/92009 > > Original issue's description: > > Switch Chrome on Linux to libc++ > > > > Design doc detailing the changes at [1], and announcement to > > chromium-dev at [2]. > > > > In addition, this CL updates perf_expectations to increase the number > > of allowed static initializers. libc++ adds some initializers from > > iostream.cpp. However, this case is net-neutral since the initializer > > used to live in libstdc++, but has been pushed into the chrome and > > nacl executables. The perf_expectations change also required adding > > NOPRESUBMIT=true to silence a bogus warning. > > > > [1] https://docs.google.com/document/d/1zmHUXlpGNXB433wHnr40dLwj7c-USsIVlyAeH7vOI9o/edit#heading=h.bfky2xssferh > > [2] https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/z2YnFCxq0MA > > > > BUG=593874 > > R=thakis@chromium.org > > TBR=rdevlin.cronin@chromium.org > > CC=thestig@chromium.org > > NOPRESUBMIT=true > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng > > > > Review-Url: https://codereview.chromium.org/2933573002 > > Cr-Commit-Position: refs/heads/master@{#483498} > > Committed: https://chromium.googlesource.com/chromium/src/+/39fcd6af4d8c9ddcf909b8d489c6ba684d046157 > > TBR=thakis@chromium.org,rdevlin.cronin@chromium.org,thomasanderson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=593874 > > Review-Url: https://codereview.chromium.org/2965693002 > Cr-Commit-Position: refs/heads/master@{#483560} > Committed: https://chromium.googlesource.com/chromium/src/+/71911249cfd027e31384c7daa1a781773545036c TBR=thakis@chromium.org,rdevlin.cronin@chromium.org,thomasanderson@chromium.org BUG=593874 NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2963223003 Cr-Commit-Position: refs/heads/master@{#483644} Committed: https://chromium.googlesource.com/chromium/src/+/805944fbd6227f618eafcc27e0bca510a640b359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -43 lines) Patch
M build/config/c++/c++.gni View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_ia32_jessie View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64_jessie View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/installer/linux/rpm/build.sh View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 3 chunks +6 lines, -14 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 3 chunks +2 lines, -9 lines 0 comments Download
M extensions/shell/installer/linux/debian/expected_deps_x64_jessie View 3 chunks +3 lines, -4 lines 0 comments Download
M tools/perf_expectations/perf_expectations.json View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
ynovikov
Created Reland of Switch Chrome on Linux to libc++
3 years, 5 months ago (2017-06-30 05:04:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963223003/1
3 years, 5 months ago (2017-06-30 05:07:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/478321)
3 years, 5 months ago (2017-06-30 05:15:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963223003/1
3 years, 5 months ago (2017-06-30 05:46:12 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 06:46:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/805944fbd6227f618eafcc27e0bc...

Powered by Google App Engine
This is Rietveld 408576698