Switch Chrome on Linux to libc++

Switch Chrome on Linux to libc++

Design doc detailing the changes at [1], and announcement to
chromium-dev at [2].

In addition, this CL updates perf_expectations to increase the number
of allowed static initializers.  libc++ adds some initializers from
iostream.cpp.  However, this case is net-neutral since the initializer
used to live in libstdc++, but has been pushed into the chrome and
nacl executables.  The perf_expectations change also required adding
NOPRESUBMIT=true to silence a bogus warning.

[1] https://docs.google.com/document/d/1zmHUXlpGNXB433wHnr40dLwj7c-USsIVlyAeH7vOI9o/edit#heading=h.bfky2xssferh
[2] https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/z2YnFCxq0MA

BUG=593874
R=thakis@chromium.org
TBR=rdevlin.cronin@chromium.org
CC=thestig@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng

Review-Url: https://codereview.chromium.org/2933573002
Cr-Commit-Position: refs/heads/master@{#483498}
Committed: https://chromium.googlesource.com/chromium/src/+/39fcd6af4d8c9ddcf909b8d489c6ba684d046157

[Tom Anderson, 2017-06-20 23:41:22]

Description was changed from

==========
[DO NOT LAND] Test enabling libc++ on non-instrumented Linux builds

BUG=593874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
==========

to

==========
Switch Chrome on Linux to libc++

BUG=593874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
NOPRESUBMIT=true
R=thakis@chromium.org
==========

[Tom Anderson, 2017-06-20 23:42:27]

Description was changed from

==========
Switch Chrome on Linux to libc++

BUG=593874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
NOPRESUBMIT=true
R=thakis@chromium.org
==========

to

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org,thestig@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

[Tom Anderson, 2017-06-20 23:43:05]

Description was changed from

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org,thestig@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

to

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org,thestig@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

[Tom Anderson, 2017-06-20 23:43:05]

thomasanderson@chromium.org changed reviewers:
+ brettw@chromium.org, thakis@chromium.org, thestig@chromium.org

[Tom Anderson, 2017-06-20 23:43:32]

Description was changed from

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org,thestig@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

to

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org,thestig@chromium.org,brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

[Tom Anderson, 2017-06-20 23:43:59]

Patchset #3 (id:40001) has been deleted

[Tom Anderson, 2017-06-20 23:44:17]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 23:44:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 23:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 23:52:58]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tom Anderson, 2017-06-20 23:58:32]

Description was changed from

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org,thestig@chromium.org,brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

to

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org,thestig@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

[Tom Anderson, 2017-06-20 23:59:30]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 00:00:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-06-21 00:07:29]

Patchset #4 (id:80001) has been deleted

[Tom Anderson, 2017-06-21 00:15:11]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 00:15:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 00:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 00:33:58]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Tom Anderson, 2017-06-21 02:39:47]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 02:40:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 02:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 02:57:53]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Tom Anderson, 2017-06-21 05:11:32]

Patchset #4 (id:100001) has been deleted

[Tom Anderson, 2017-06-22 04:38:49]

Patchset #4 (id:120001) has been deleted

[Tom Anderson, 2017-06-22 04:45:55]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 04:46:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 05:25:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 05:25:08]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Tom (Use chromium acct), 2017-06-27 01:57:36]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 01:57:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 02:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 02:44:34]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm/build...)

[Tom Anderson, 2017-06-27 17:41:56]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 17:42:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-06-27 17:43:43]

Description was changed from

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org,thestig@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

to

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org,jochen@chromium.org
CC=thestig@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

[Tom Anderson, 2017-06-27 17:43:43]

thomasanderson@chromium.org changed reviewers:
+ jochen@chromium.org
- brettw@chromium.org, thestig@chromium.org, thomasanderson@google.com

[Tom Anderson, 2017-06-27 19:02:49]

Patchset #5 (id:160001) has been deleted

[Tom Anderson, 2017-06-27 19:03:14]

Description was changed from

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org,jochen@chromium.org
CC=thestig@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

to

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org
TBR=jochen@chromium.org
CC=thestig@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

[commit-bot: I haz the power, 2017-06-27 19:18:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2017-06-27 20:18:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 20:18:38]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm/build...)

[Tom (Use chromium acct), 2017-06-27 20:20:56]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 20:21:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 21:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 21:04:12]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm/build...)

[Tom Anderson, 2017-06-27 21:32:52]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 21:33:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 21:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 21:48:20]

Dry run: This issue passed the CQ dry run.

[Tom Anderson, 2017-06-28 18:14:17]

thakis ptal

[jochen (gone - plz use gerrit), 2017-06-28 18:15:49]

what am I being TBR'ed for?

[Tom Anderson, 2017-06-28 18:17:55]

On 2017/06/28 18:15:49, jochen wrote:
> what am I being TBR'ed for?

extensions/shell/installer/linux/debian/expected_deps_x64_jessie

[Nico, 2017-06-28 18:20:08]

As said yesterday, let's finish our doc (on it, on it) and send an intent to
implement first.

[Nico, 2017-06-29 18:30:54]

lgtm!

https://codereview.chromium.org/2933573002/diff/140001/build/config/c++/c++.gni
File build/config/c++/c++.gni (right):

https://codereview.chromium.org/2933573002/diff/140001/build/config/c++/c++.g...
build/config/c++/c++.gni:16: (is_linux && !is_chromeos) ||
The next line suggests that this wants to be is_linux && !is_chromeos &&
(!is_chromecast || is_cast_desktop_build). You can also remove the next line
then.

I think you can almost remove the whole rest of the line – we only use tsan and
msan on linux. This is probably also true for ubsan, and we don't want to use
custom_libcxx on mac (at least atm) so we don't need the libfuzzer bit. But
maybe safer to not do that in this change.

https://codereview.chromium.org/2933573002/diff/140001/chrome/installer/linux...
File chrome/installer/linux/debian/expected_deps_ia32_jessie (left):

https://codereview.chromium.org/2933573002/diff/140001/chrome/installer/linux...
chrome/installer/linux/debian/expected_deps_ia32_jessie:20: libstdc++6 (>=
4.8.1)
:-)

https://codereview.chromium.org/2933573002/diff/140001/tools/perf_expectation...
File tools/perf_expectations/perf_expectations.json (right):

https://codereview.chromium.org/2933573002/diff/140001/tools/perf_expectation...
tools/perf_expectations/perf_expectations.json:1:
{"linux-release-64/sizes/chrome-si/initializers": {"reva": 480969, "revb":
480969, "type": "absolute", "better": "lower", "improve": 8, "regress": 8,
"tolerance": 0, "sha1": "de779422"},
Please say in the CL description that the c++ standard library contains a static
initializer and that this CL moves it from a .so into chrome. (In general, we
never accept CLs that increase this number, but in this case it's net-neutral so
it's ok.)

[jochen (gone - plz use gerrit), 2017-06-29 18:51:44]

Please ask rdevlin.cronin@ to review that file (or TBR it to them). I don't know
what this file is

[Tom Anderson, 2017-06-29 19:24:53]

thomasanderson@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org
- jochen@chromium.org, thomasanderson@google.com

[Tom Anderson, 2017-06-29 19:34:58]

Description was changed from

==========
Switch Chrome on Linux to libc++

BUG=593874
R=thakis@chromium.org
TBR=jochen@chromium.org
CC=thestig@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

to

==========
Switch Chrome on Linux to libc++

Design doc detailing the changes at [1], and announcement to
chromium-dev at [2].

In addition, this CL updates perf_expectations to increase the number
of allowed static initializers.  libc++ adds some initializers from
iostream.cpp.  However, this case is net-neutral since the initializer
used to live in libstdc++, but has been pushed into the chrome and
nacl executables.  The perf_expectations change also required adding
NOPRESUBMIT=true to silence a bogus warning.

[1]
https://docs.google.com/document/d/1zmHUXlpGNXB433wHnr40dLwj7c-USsIVlyAeH7vOI...
[2]
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-de...

BUG=593874
R=thakis@chromium.org
TBR=rdevlin.cronin@chromium.org
CC=thestig@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

[Tom Anderson, 2017-06-29 19:42:11]

On 2017/06/29 18:51:44, jochen wrote:
> Please ask rdevlin.cronin@ to review that file (or TBR it to them). I don't
know
> what this file is

+rdevlin.cronin

https://codereview.chromium.org/2933573002/diff/140001/build/config/c++/c++.gni
File build/config/c++/c++.gni (right):

https://codereview.chromium.org/2933573002/diff/140001/build/config/c++/c++.g...
build/config/c++/c++.gni:16: (is_linux && !is_chromeos) ||
On 2017/06/29 18:30:54, Nico (vacation Jun 30-Jul 11) wrote:
> The next line suggests that this wants to be is_linux && !is_chromeos &&
> (!is_chromecast || is_cast_desktop_build). You can also remove the next line
> then.
> 
> I think you can almost remove the whole rest of the line – we only use tsan
and
> msan on linux. This is probably also true for ubsan, and we don't want to use
> custom_libcxx on mac (at least atm) so we don't need the libfuzzer bit. But
> maybe safer to not do that in this change.

Done.  I'll hold off on changing the second half so I added a TODO in the
meantime explaining what still needs to be cleaned up.

https://codereview.chromium.org/2933573002/diff/140001/tools/perf_expectation...
File tools/perf_expectations/perf_expectations.json (right):

https://codereview.chromium.org/2933573002/diff/140001/tools/perf_expectation...
tools/perf_expectations/perf_expectations.json:1:
{"linux-release-64/sizes/chrome-si/initializers": {"reva": 480969, "revb":
480969, "type": "absolute", "better": "lower", "improve": 8, "regress": 8,
"tolerance": 0, "sha1": "de779422"},
On 2017/06/29 18:30:54, Nico (vacation Jun 30-Jul 11) wrote:
> Please say in the CL description that the c++ standard library contains a
static
> initializer and that this CL moves it from a .so into chrome. (In general, we
> never accept CLs that increase this number, but in this case it's net-neutral
so
> it's ok.)

Done.

[Tom Anderson, 2017-06-29 19:42:20]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 19:42:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-29 20:26:42]

extensions/shell/installer lgtm (looks fine, but mostly trusting Nico).

+Michael FYI.

[commit-bot: I haz the power, 2017-06-29 21:37:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 21:37:41]

Dry run: This issue passed the CQ dry run.

[Tom Anderson, 2017-06-29 21:43:12]

The CQ bit was checked by thomasanderson@chromium.org

[Tom Anderson, 2017-06-29 21:43:12]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2933573002/#ps180001
(title: "Simplify use_custom_libcxx conditions")

[commit-bot: I haz the power, 2017-06-29 21:43:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 21:43:54]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1498772592631300,
"parent_rev": "72014f6a8ab12897583185fc6c5b4752fcbaa278", "commit_rev":
"39fcd6af4d8c9ddcf909b8d489c6ba684d046157"}

[commit-bot: I haz the power, 2017-06-29 21:44:09]

Description was changed from

==========
Switch Chrome on Linux to libc++

Design doc detailing the changes at [1], and announcement to
chromium-dev at [2].

In addition, this CL updates perf_expectations to increase the number
of allowed static initializers.  libc++ adds some initializers from
iostream.cpp.  However, this case is net-neutral since the initializer
used to live in libstdc++, but has been pushed into the chrome and
nacl executables.  The perf_expectations change also required adding
NOPRESUBMIT=true to silence a bogus warning.

[1]
https://docs.google.com/document/d/1zmHUXlpGNXB433wHnr40dLwj7c-USsIVlyAeH7vOI...
[2]
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-de...

BUG=593874
R=thakis@chromium.org
TBR=rdevlin.cronin@chromium.org
CC=thestig@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
==========

to

==========
Switch Chrome on Linux to libc++

Design doc detailing the changes at [1], and announcement to
chromium-dev at [2].

In addition, this CL updates perf_expectations to increase the number
of allowed static initializers.  libc++ adds some initializers from
iostream.cpp.  However, this case is net-neutral since the initializer
used to live in libstdc++, but has been pushed into the chrome and
nacl executables.  The perf_expectations change also required adding
NOPRESUBMIT=true to silence a bogus warning.

[1]
https://docs.google.com/document/d/1zmHUXlpGNXB433wHnr40dLwj7c-USsIVlyAeH7vOI...
[2]
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-de...

BUG=593874
R=thakis@chromium.org
TBR=rdevlin.cronin@chromium.org
CC=thestig@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng

Review-Url: https://codereview.chromium.org/2933573002
Cr-Commit-Position: refs/heads/master@{#483498}
Committed:
https://chromium.googlesource.com/chromium/src/+/39fcd6af4d8c9ddcf909b8d489c6...
==========

[commit-bot: I haz the power, 2017-06-29 21:44:11]

Committed patchset #5 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/39fcd6af4d8c9ddcf909b8d489c6...

[ynovikov, 2017-06-30 00:26:59]

A revert of this CL (patchset #5 id:180001) has been created in
https://codereview.chromium.org/2965693002/ by ynovikov@chromium.org.

The reason for reverting is: Breaks
https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/....