Revert of Switch Chrome on Linux to libc++

Revert of Switch Chrome on Linux to libc++ (patchset #5 id:180001 of https://codereview.chromium.org/2933573002/ )

Reason for revert:
Breaks https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/92009

Original issue's description:
> Switch Chrome on Linux to libc++
> 
> Design doc detailing the changes at [1], and announcement to
> chromium-dev at [2].
> 
> In addition, this CL updates perf_expectations to increase the number
> of allowed static initializers.  libc++ adds some initializers from
> iostream.cpp.  However, this case is net-neutral since the initializer
> used to live in libstdc++, but has been pushed into the chrome and
> nacl executables.  The perf_expectations change also required adding
> NOPRESUBMIT=true to silence a bogus warning.
> 
> [1] https://docs.google.com/document/d/1zmHUXlpGNXB433wHnr40dLwj7c-USsIVlyAeH7vOI9o/edit#heading=h.bfky2xssferh
> [2] https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/z2YnFCxq0MA
> 
> BUG=593874
> R=thakis@chromium.org
> TBR=rdevlin.cronin@chromium.org
> CC=thestig@chromium.org
> NOPRESUBMIT=true
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
> 
> Review-Url: https://codereview.chromium.org/2933573002
> Cr-Commit-Position: refs/heads/master@{#483498}
> Committed: https://chromium.googlesource.com/chromium/src/+/39fcd6af4d8c9ddcf909b8d489c6ba684d046157

TBR=thakis@chromium.org,rdevlin.cronin@chromium.org,thomasanderson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=593874
Review-Url: https://codereview.chromium.org/2965693002
Cr-Commit-Position: refs/heads/master@{#483560}
Committed: https://chromium.googlesource.com/chromium/src/+/71911249cfd027e31384c7daa1a781773545036c

[ynovikov, 2017-06-30 00:26:59]

The CQ bit was checked by ynovikov@chromium.org

[ynovikov, 2017-06-30 00:27:00]

Created Revert of Switch Chrome on Linux to libc++

[commit-bot: I haz the power, 2017-06-30 00:27:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 00:27:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498782419508330, "parent_rev":
"3fc0df1e01ab7e17318ce50724890f939bc00fa4", "commit_rev":
"9729914e63acd9d341784bd9686fb7dec10075c4"}

[commit-bot: I haz the power, 2017-06-30 00:28:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498782419508330, "parent_rev":
"1f3818e301454f1614ca79616db997ba3e0b7d27", "commit_rev":
"71911249cfd027e31384c7daa1a781773545036c"}

[commit-bot: I haz the power, 2017-06-30 00:28:19]

Description was changed from

==========
Revert of Switch Chrome on Linux to libc++ (patchset #5 id:180001 of
https://codereview.chromium.org/2933573002/ )

Reason for revert:
Breaks
https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/...

Original issue's description:
> Switch Chrome on Linux to libc++
> 
> Design doc detailing the changes at [1], and announcement to
> chromium-dev at [2].
> 
> In addition, this CL updates perf_expectations to increase the number
> of allowed static initializers.  libc++ adds some initializers from
> iostream.cpp.  However, this case is net-neutral since the initializer
> used to live in libstdc++, but has been pushed into the chrome and
> nacl executables.  The perf_expectations change also required adding
> NOPRESUBMIT=true to silence a bogus warning.
> 
> [1]
https://docs.google.com/document/d/1zmHUXlpGNXB433wHnr40dLwj7c-USsIVlyAeH7vOI...
> [2]
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-de...
> 
> BUG=593874
> R=thakis@chromium.org
> TBR=rdevlin.cronin@chromium.org
> CC=thestig@chromium.org
> NOPRESUBMIT=true
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
> 
> Review-Url: https://codereview.chromium.org/2933573002
> Cr-Commit-Position: refs/heads/master@{#483498}
> Committed:
https://chromium.googlesource.com/chromium/src/+/39fcd6af4d8c9ddcf909b8d489c6...

TBR=thakis@chromium.org,rdevlin.cronin@chromium.org,thomasanderson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=593874
==========

to

==========
Revert of Switch Chrome on Linux to libc++ (patchset #5 id:180001 of
https://codereview.chromium.org/2933573002/ )

Reason for revert:
Breaks
https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/...

Original issue's description:
> Switch Chrome on Linux to libc++
> 
> Design doc detailing the changes at [1], and announcement to
> chromium-dev at [2].
> 
> In addition, this CL updates perf_expectations to increase the number
> of allowed static initializers.  libc++ adds some initializers from
> iostream.cpp.  However, this case is net-neutral since the initializer
> used to live in libstdc++, but has been pushed into the chrome and
> nacl executables.  The perf_expectations change also required adding
> NOPRESUBMIT=true to silence a bogus warning.
> 
> [1]
https://docs.google.com/document/d/1zmHUXlpGNXB433wHnr40dLwj7c-USsIVlyAeH7vOI...
> [2]
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-de...
> 
> BUG=593874
> R=thakis@chromium.org
> TBR=rdevlin.cronin@chromium.org
> CC=thestig@chromium.org
> NOPRESUBMIT=true
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_arm;master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
> 
> Review-Url: https://codereview.chromium.org/2933573002
> Cr-Commit-Position: refs/heads/master@{#483498}
> Committed:
https://chromium.googlesource.com/chromium/src/+/39fcd6af4d8c9ddcf909b8d489c6...

TBR=thakis@chromium.org,rdevlin.cronin@chromium.org,thomasanderson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=593874

Review-Url: https://codereview.chromium.org/2965693002
Cr-Commit-Position: refs/heads/master@{#483560}
Committed:
https://chromium.googlesource.com/chromium/src/+/71911249cfd027e31384c7daa1a7...
==========

[commit-bot: I haz the power, 2017-06-30 00:28:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/71911249cfd027e31384c7daa1a7...

[Nico, 2017-06-30 01:37:13]

On 2017/06/30 00:28:20, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/71911249cfd027e31384c7daa1a7...

Going forward, let's not immediately revert on fyi breakage. Fyi bots are not
fully supported.

[ynovikov, 2017-06-30 01:47:48]

On 2017/06/30 01:37:13, Nico (vacation Jun 30-Jul 11) wrote:
> On 2017/06/30 00:28:20, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/71911249cfd027e31384c7daa1a7...
> 
> Going forward, let's not immediately revert on fyi breakage. Fyi bots are not
> fully supported.

Ah, sorry. But, this fyi bot is mirrored by linux_optional_gpu_tests_rel.
Even though it is optional, it's included in CQ by many CLs, so this prevented
this skia roll from landing, for example:
https://chromium-review.googlesource.com/557362.
As well as this v8 roll: https://codereview.chromium.org/2961353003.
And couple of other CLs.

[Nico, 2017-06-30 01:52:29]

That's a bug then. We should not have hard dependencies on fyi bots.

(kbr: depq using exceptions keeps causing headaches. I'd really like to see
some bug to convert it to Google style eventually. If it stays on fyi
before that has happened, there's no rush, but then nothing prodlike should
depend on those bots.)

On Jun 29, 2017 9:47 PM, <ynovikov@chromium.org> wrote:

> On 2017/06/30 01:37:13, Nico (vacation Jun 30-Jul 11) wrote:
> > On 2017/06/30 00:28:20, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > >
> >
> https://chromium.googlesource.com/chromium/src/+/
> 71911249cfd027e31384c7daa1a781773545036c
> >
> > Going forward, let's not immediately revert on fyi breakage. Fyi bots
> are not
> > fully supported.
>
> Ah, sorry. But, this fyi bot is mirrored by linux_optional_gpu_tests_rel.
> Even though it is optional, it's included in CQ by many CLs, so this
> prevented
> this skia roll from landing, for example:
> https://chromium-review.googlesource.com/557362.
> As well as this v8 roll: https://codereview.chromium.org/2961353003.
> And couple of other CLs.
>
>
> https://codereview.chromium.org/2965693002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ynovikov, 2017-06-30 05:04:49]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2963223003/ by ynovikov@chromium.org.

The reason for reverting is: ANGLE compilation issues should be fixed by
https://chromium-review.googlesource.com/557679.