Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2963213002: Polymer: Remove unused paper-dialog and paper-dialog-behavior. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Polymer: Remove unused paper-dialog and paper-dialog-behavior. BUG=720781 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2963213002 Cr-Commit-Position: refs/heads/master@{#483554} Committed: https://chromium.googlesource.com/chromium/src/+/4a140b8e1f361cdaf3a13e3c620a6bbe84ca7882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -534 lines) Patch
M third_party/polymer/v1_0/bower.json View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/bower.json View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js View 1 chunk +0 lines, -123 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-common.css View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-shared-styles.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog/bower.json View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog.html View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog-extracted.js View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 chunk +0 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
dpapad
3 years, 5 months ago (2017-06-29 23:34:27 UTC) #5
michaelpg
LGTM!
3 years, 5 months ago (2017-06-29 23:35:22 UTC) #6
dpapad
On 2017/06/29 at 23:35:22, michaelpg wrote: > LGTM! Thanks!
3 years, 5 months ago (2017-06-29 23:37:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963213002/1
3 years, 5 months ago (2017-06-29 23:44:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4a140b8e1f361cdaf3a13e3c620a6bbe84ca7882
3 years, 5 months ago (2017-06-30 00:09:46 UTC) #13
oka
3 years, 5 months ago (2017-07-04 06:57:53 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2969003002/ by oka@chromium.org.

The reason for reverting is: It caused http://crbug.com/738826.

Powered by Google App Engine
This is Rietveld 408576698