Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2961103003: CrOS OOBE login: Replace last usages of paper-dialog with cr-dialog. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
michaelpg
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CrOS OOBE login: Replace last usages of paper-dialog with cr-dialog. BUG=720781 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2961103003 Cr-Commit-Position: refs/heads/master@{#483508} Committed: https://chromium.googlesource.com/chromium/src/+/df39d072bdadb328ed3c1a3ae7bf245512e09fe8

Patch Set 1 : Fix tests. #

Patch Set 2 : Tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -49 lines) Patch
M chrome/browser/resources/chromeos/login/offline_gaia.css View 1 1 chunk +3 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/login/offline_gaia.html View 1 4 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/offline_gaia.js View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/saml_confirm_password.css View 1 1 chunk +3 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/login/saml_confirm_password.html View 3 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/resources/chromeos/login/saml_confirm_password.js View 2 chunks +9 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (24 generated)
dpapad
Before/after screenshots at http://imgur.com/a/gGUtv and http://imgur.com/a/TteXd.
3 years, 5 months ago (2017-06-29 01:54:21 UTC) #20
michaelpg
lgtm
3 years, 5 months ago (2017-06-29 21:59:39 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961103003/100001
3 years, 5 months ago (2017-06-29 22:02:33 UTC) #25
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 22:06:58 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/df39d072bdadb328ed3c1a3ae7bf...

Powered by Google App Engine
This is Rietveld 408576698