Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2969003002: Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior. (Closed)

Created:
3 years, 5 months ago by oka
Modified:
3 years, 5 months ago
Reviewers:
michaelpg, dpapad
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior. (patchset #1 id:1 of https://codereview.chromium.org/2963213002/ ) Reason for revert: It caused http://crbug.com/738826 BUG=738826, 720781 Original issue's description: > Polymer: Remove unused paper-dialog and paper-dialog-behavior. > > BUG=720781 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2963213002 > Cr-Commit-Position: refs/heads/master@{#483554} > Committed: https://chromium.googlesource.com/chromium/src/+/4a140b8e1f361cdaf3a13e3c620a6bbe84ca7882 TBR=michaelpg@chromium.org,dpapad@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=720781 Review-Url: https://codereview.chromium.org/2969003002 Cr-Commit-Position: refs/heads/master@{#484071} Committed: https://chromium.googlesource.com/chromium/src/+/7b449e1b8f24470071fc6d07df3f42e0d914a484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+534 lines, -0 lines) Patch
M third_party/polymer/v1_0/bower.json View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/bower.json View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js View 1 chunk +123 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-common.css View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-shared-styles.html View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog/bower.json View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog.html View 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog/paper-dialog-extracted.js View 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
oka
Created Revert of Polymer: Remove unused paper-dialog and paper-dialog-behavior.
3 years, 5 months ago (2017-07-04 06:57:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969003002/1
3 years, 5 months ago (2017-07-04 06:58:07 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 09:03:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b449e1b8f24470071fc6d07df3f...

Powered by Google App Engine
This is Rietveld 408576698