Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2962043002: The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly. (Closed)

Created:
3 years, 5 months ago by wangyix1
Modified:
3 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly. gfe/quic/core/frames/quic_frames_test.cc no longer uses them. Merge internal change: 159564609 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
M net/quic/core/frames/quic_ack_frame.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/frames/quic_ack_frame.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/core/frames/quic_frames_test.cc View 4 chunks +15 lines, -20 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2963863002 Patch 20001

Dependent Patchsets:

Issue 2961133002 Patch 20001

Messages

Total messages: 10 (8 generated)
wangyix1
3 years, 5 months ago (2017-06-28 19:13:12 UTC) #1
Ryan Hamilton
3 years, 5 months ago (2017-06-29 02:52:45 UTC) #10 
lgtm

Powered by Google App Engine
This is Rietveld 408576698