Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2963863002: Allow trailing headers with duplicate keys. Protected by FLAGS_quic_reloadable_flag_quic_allow_dupl… (Closed)

Created:
3 years, 5 months ago by wangyix1
Modified:
3 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow trailing headers with duplicate keys. Protected by FLAGS_quic_reloadable_flag_quic_allow_duplicate_trailers QUIC currently treats trailers with duplicate header keys as a critical failure (causing a CONNECION_CLOSE with QUIC_INVALID_HEADERS_STREAM_DATA). See b/62770138. This doesn't seem to be implementing the spec, as RFC 7541 says: "The dynamic table can contain duplicate entries (i.e., entries with the same name and same value). Therefore, duplicate entries MUST NOT be treated as an error by a decoder." In addition, it doesn't look like our spdy/http2 implementation does any sort of similar validation check. This CL makes QUIC more permissive of trailing headers, brings it in line with our HTTP/2 implementation, and (hopefully) fixes b/62770138. Merge internal change: 159476633 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -9 lines) Patch
M net/quic/core/quic_flags_list.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/spdy_utils.cc View 3 chunks +19 lines, -6 lines 0 comments Download
M net/quic/core/spdy_utils_test.cc View 3 chunks +38 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (8 generated)
wangyix1
3 years, 5 months ago (2017-06-28 19:09:46 UTC) #1
Ryan Hamilton
3 years, 5 months ago (2017-06-29 02:52:59 UTC) #10
lgtm

Powered by Google App Engine
This is Rietveld 408576698