Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: net/quic/core/frames/quic_ack_frame.h

Issue 2962043002: The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly. (Closed)
Patch Set: Rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/core/frames/quic_ack_frame.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_CORE_FRAMES_QUIC_ACK_FRAME_H_ 5 #ifndef NET_QUIC_CORE_FRAMES_QUIC_ACK_FRAME_H_
6 #define NET_QUIC_CORE_FRAMES_QUIC_ACK_FRAME_H_ 6 #define NET_QUIC_CORE_FRAMES_QUIC_ACK_FRAME_H_
7 7
8 #include <ostream> 8 #include <ostream>
9 #include <string> 9 #include <string>
10 10
(...skipping 21 matching lines...) Expand all
32 PacketNumberQueue& operator=(PacketNumberQueue&& other); 32 PacketNumberQueue& operator=(PacketNumberQueue&& other);
33 33
34 // Adds |packet_number| to the set of packets in the queue. 34 // Adds |packet_number| to the set of packets in the queue.
35 void Add(QuicPacketNumber packet_number); 35 void Add(QuicPacketNumber packet_number);
36 36
37 // Adds packets between [lower, higher) to the set of packets in the queue. It 37 // Adds packets between [lower, higher) to the set of packets in the queue. It
38 // is undefined behavior to call this with |higher| < |lower|. 38 // is undefined behavior to call this with |higher| < |lower|.
39 void Add(QuicPacketNumber lower, QuicPacketNumber higher); 39 void Add(QuicPacketNumber lower, QuicPacketNumber higher);
40 40
41 // Removes |packet_number| from the set of packets in the queue. 41 // Removes |packet_number| from the set of packets in the queue.
42 void Remove(QuicPacketNumber packet_number); 42 void RemoveTestOnly(QuicPacketNumber packet_number);
43 43
44 // Removes packets numbers between [lower, higher) to the set of packets in 44 // Removes packets numbers between [lower, higher) to the set of packets in
45 // the queue. It is undefined behavior to call this with |higher| < |lower|. 45 // the queue. It is undefined behavior to call this with |higher| < |lower|.
46 void Remove(QuicPacketNumber lower, QuicPacketNumber higher); 46 void RemoveTestOnly(QuicPacketNumber lower, QuicPacketNumber higher);
47 47
48 // Removes packets with values less than |higher| from the set of packets in 48 // Removes packets with values less than |higher| from the set of packets in
49 // the queue. Returns true if packets were removed. 49 // the queue. Returns true if packets were removed.
50 bool RemoveUpTo(QuicPacketNumber higher); 50 bool RemoveUpTo(QuicPacketNumber higher);
51 51
52 // Removes the smallest interval in the queue. 52 // Removes the smallest interval in the queue.
53 void RemoveSmallestInterval(); 53 void RemoveSmallestInterval();
54 54
55 // Returns true if the queue contains |packet_number|. 55 // Returns true if the queue contains |packet_number|.
56 bool Contains(QuicPacketNumber packet_number) const; 56 bool Contains(QuicPacketNumber packet_number) const;
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 // as missing. 117 // as missing.
118 // Always returns false for packet numbers less than least_unacked. 118 // Always returns false for packet numbers less than least_unacked.
119 QUIC_EXPORT_PRIVATE bool IsAwaitingPacket( 119 QUIC_EXPORT_PRIVATE bool IsAwaitingPacket(
120 const QuicAckFrame& ack_frame, 120 const QuicAckFrame& ack_frame,
121 QuicPacketNumber packet_number, 121 QuicPacketNumber packet_number,
122 QuicPacketNumber peer_least_packet_awaiting_ack); 122 QuicPacketNumber peer_least_packet_awaiting_ack);
123 123
124 } // namespace net 124 } // namespace net
125 125
126 #endif // NET_QUIC_CORE_FRAMES_QUIC_ACK_FRAME_H_ 126 #endif // NET_QUIC_CORE_FRAMES_QUIC_ACK_FRAME_H_
OLDNEW
« no previous file with comments | « no previous file | net/quic/core/frames/quic_ack_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698