Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: net/quic/core/quic_sent_packet_manager_test.cc

Issue 2962043002: The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly. (Closed)
Patch Set: Rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/core/quic_connection_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/core/quic_sent_packet_manager.h" 5 #include "net/quic/core/quic_sent_packet_manager.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "net/quic/core/quic_pending_retransmission.h" 9 #include "net/quic/core/quic_pending_retransmission.h"
10 #include "net/quic/platform/api/quic_flags.h" 10 #include "net/quic/platform/api/quic_flags.h"
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 if (largest_observed > 0) { 259 if (largest_observed > 0) {
260 frame.packets.Add(1, largest_observed + 1); 260 frame.packets.Add(1, largest_observed + 1);
261 } 261 }
262 return frame; 262 return frame;
263 } 263 }
264 264
265 // Explicitly nack packet [lower, higher). 265 // Explicitly nack packet [lower, higher).
266 void NackPackets(QuicPacketNumber lower, 266 void NackPackets(QuicPacketNumber lower,
267 QuicPacketNumber higher, 267 QuicPacketNumber higher,
268 QuicAckFrame* frame) { 268 QuicAckFrame* frame) {
269 frame->packets.Remove(lower, higher); 269 frame->packets.RemoveTestOnly(lower, higher);
270 } 270 }
271 271
272 QuicSentPacketManager manager_; 272 QuicSentPacketManager manager_;
273 MockClock clock_; 273 MockClock clock_;
274 QuicConnectionStats stats_; 274 QuicConnectionStats stats_;
275 MockSendAlgorithm* send_algorithm_; 275 MockSendAlgorithm* send_algorithm_;
276 std::unique_ptr<MockNetworkChangeVisitor> network_change_visitor_; 276 std::unique_ptr<MockNetworkChangeVisitor> network_change_visitor_;
277 }; 277 };
278 278
279 TEST_F(QuicSentPacketManagerTest, IsUnacked) { 279 TEST_F(QuicSentPacketManagerTest, IsUnacked) {
(...skipping 1511 matching lines...) Expand 10 before | Expand all | Expand 10 after
1791 ExpectAck(1); 1791 ExpectAck(1);
1792 EXPECT_CALL(*network_change_visitor_, 1792 EXPECT_CALL(*network_change_visitor_,
1793 OnPathMtuIncreased(kDefaultLength + 100)); 1793 OnPathMtuIncreased(kDefaultLength + 100));
1794 QuicAckFrame ack_frame = InitAckFrame(1); 1794 QuicAckFrame ack_frame = InitAckFrame(1);
1795 manager_.OnIncomingAck(ack_frame, clock_.Now()); 1795 manager_.OnIncomingAck(ack_frame, clock_.Now());
1796 } 1796 }
1797 1797
1798 } // namespace 1798 } // namespace
1799 } // namespace test 1799 } // namespace test
1800 } // namespace net 1800 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/core/quic_connection_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698