Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2960263002: [DevTools] Move pixel tests from inspector-protocol to inspector (Closed)

Created:
3 years, 5 months ago by dgozman
Modified:
3 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move pixel tests from inspector-protocol to inspector BUG=734762 Review-Url: https://codereview.chromium.org/2960263002 Cr-Commit-Position: refs/heads/master@{#483602} Committed: https://chromium.googlesource.com/chromium/src/+/b73990b490ec7e22dccb936563deb30af0735142

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -556 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/default-background-color.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/default-background-color-cleared.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/default-background-color-cleared-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/default-background-color-expected.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-far.html View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-far-expected.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-far-layered.html View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-far-layered-expected.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-near.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-near-expected.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-reset.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-reset-expected.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-unobserved.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-unobserved-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/device-mode/default-background-color.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/device-mode/default-background-color-cleared.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/default-background-color-cleared-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/default-background-color-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-far.html View 2 chunks +6 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-far-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-far-layered.html View 2 chunks +6 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-far-layered-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-near.html View 2 chunks +7 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-near-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-reset.html View 2 chunks +7 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-reset-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-unobserved.html View 1 1 chunk +63 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-unobserved-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
dgozman
Take a look please.
3 years, 5 months ago (2017-06-28 19:54:49 UTC) #3
lushnikov
lgtm
3 years, 5 months ago (2017-06-28 23:07:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960263002/1
3 years, 5 months ago (2017-06-28 23:11:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/476802)
3 years, 5 months ago (2017-06-28 23:21:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960263002/20001
3 years, 5 months ago (2017-06-30 01:29:35 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 02:47:39 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b73990b490ec7e22dccb936563de...

Powered by Google App Engine
This is Rietveld 408576698