third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-reset.html - Issue 2960263002: [DevTools] Move pixel tests from inspector-protocol to inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-reset.html

Issue 2960263002: [DevTools] Move pixel tests from inspector-protocol to inspector (Closed)

Patch Set: rebased Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-near-expected.html ('k') | third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-reset-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-reset.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-reset.html b/third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-reset.html

similarity index 62%

rename from third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-reset.html

rename to third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-reset.html

index 55f5b30f8f82b2fb6fb27794ffba5c626446d093..83bdf0487c26565e0fc5dd83972fb54e32658401 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-reset.html

+++ b/third_party/WebKit/LayoutTests/inspector/device-mode/forced-viewport-reset.html

@@ -1,7 +1,7 @@

<html>

<head>

-<script src="../../http/tests/inspector-protocol/resources/inspector-protocol-test.js"></script>

+<script src="../../http/tests/inspector/inspector-test.js"></script>

<style>

html {

@@ -36,19 +36,20 @@ body {

function test()

{

- InspectorTest.sendCommand("Runtime.evaluate", { "expression": "testRunner.dumpAsTextWithPixelResults();"} );

- InspectorTest.sendCommand("Emulation.forceViewport", { "x": 200, "y": 9000, "scale": 2.0 }, overrideActive);

+ InspectorTest.evaluateInPage("testRunner.dumpAsTextWithPixelResults();", () => {

+ InspectorTest.EmulationAgent.invoke_forceViewport({x: 200, y: 9000, scale: 2.0}).then(overrideActive);

+ });

function overrideActive()

{

- InspectorTest.sendCommand("Emulation.resetViewport", {}, overrideCleared);

+ InspectorTest.EmulationAgent.invoke_resetViewport({}).then(overrideCleared);

}

function overrideCleared()

{

// Complete the test without closing the inspector, so that the override stays active for the picture.

- InspectorTest.sendCommand("Runtime.evaluate", { "expression": "testRunner.notifyDone();"} );

+ InspectorTest.flushResults();

+ InspectorTest.evaluateInPage("testRunner.notifyDone();");

}

</script>