[DevTools] Migrate inspector-protocol/debugger tests to new harness

[DevTools] Migrate inspector-protocol/debugger tests to new harness

BUG=734762
Review-Url: https://codereview.chromium.org/2968523003
Cr-Commit-Position: refs/heads/master@{#484356}
Committed: https://chromium.googlesource.com/chromium/src/+/17838a4e7eb968be5bbd182d8052a1ccb7e06752

[dgozman, 2017-06-30 01:29:40]

dgozman@chromium.org changed reviewers:
+ chenwilliam@chromium.org

[dgozman, 2017-06-30 01:29:40]

Could you please take a look?

[dgozman, 2017-06-30 19:11:58]

Description was changed from

==========
[DevTools] Migrate some of inspector-protocol/debugger tests to new harness

BUG=734762
==========

to

==========
[DevTools] Migrate inspector-protocol/debugger tests to new harness

BUG=734762
==========

[chenwilliam, 2017-06-30 20:23:27]

lgtm. you're a machine! left a few minor comments.

https://codereview.chromium.org/2968523003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/debugger/access-obsolete-frame.js
(right):

https://codereview.chromium.org/2968523003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/debugger/access-obsolete-frame.js:2:
let {page, session, dp} = await testRunner.startBlank('');
dp stands for Debugger Protocol? Personally, I don't like abbreviations, but if
we want to be more succinct, might as well rename all testRunner -> t since it's
a convention with some JS testing libraries:
https://github.com/substack/tape#example

https://codereview.chromium.org/2968523003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/debugger/call-frame-functionLocation.js
(right):

https://codereview.chromium.org/2968523003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/debugger/call-frame-functionLocation.js:6:

I'm guessing the empty lines is just to preserve line number in the golden file?
Let's remove these historical empty lines in a second pass? It's not intuitive
to a reader why we have 4 empty lines in a test.

https://codereview.chromium.org/2968523003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.js
(right):

https://codereview.chromium.org/2968523003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.js:4:
function statementsExample()
should we standardize on whether to have inspected page functions be in template
string or use .toString()?

https://codereview.chromium.org/2968523003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.js
(right):

https://codereview.chromium.org/2968523003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.js:2:
let {page, session, dp} = await testRunner.startBlank('Check that stepInto at
then end of the script go to next user script instead
InjectedScriptSource.js.');
typo: s/then end/the end

[dgozman, 2017-06-30 20:48:05]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-06-30 20:48:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 20:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 20:48:34]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[pfeldman, 2017-07-05 18:47:11]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2017-07-05 18:47:11]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-07-05 18:47:12]

lgtm

[commit-bot: I haz the power, 2017-07-05 18:47:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 19:08:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 19:08:10]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kozy, 2017-07-05 19:10:31]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-07-05 19:10:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 19:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 19:45:37]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kozy, 2017-07-05 20:54:12]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-07-05 20:54:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 21:33:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499288052430080,
"parent_rev": "3218b77ab1c9e3176c585e19783df48641e3ef9a", "commit_rev":
"17838a4e7eb968be5bbd182d8052a1ccb7e06752"}

[commit-bot: I haz the power, 2017-07-05 21:34:09]

Description was changed from

==========
[DevTools] Migrate inspector-protocol/debugger tests to new harness

BUG=734762
==========

to

==========
[DevTools] Migrate inspector-protocol/debugger tests to new harness

BUG=734762

Review-Url: https://codereview.chromium.org/2968523003
Cr-Commit-Position: refs/heads/master@{#484356}
Committed:
https://chromium.googlesource.com/chromium/src/+/17838a4e7eb968be5bbd182d8052...
==========

[commit-bot: I haz the power, 2017-07-05 21:34:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17838a4e7eb968be5bbd182d8052...