Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2959893002: FramebufferRenderbuffer() generates INVALID_OP if renderbuffer has never been bound. (Closed)

Created:
3 years, 5 months ago by Zhenyao Mo
Modified:
3 years, 5 months ago
CC:
chromium-reviews, haraken, piman+watch_chromium.org, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

FramebufferRenderbuffer() generates INVALID_OP if renderbuffer has never been bound. BUG=736916 TEST=gpu_unittests,webgl_conformance R=kbr@chromium.org,kainino@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2959893002 Cr-Commit-Position: refs/heads/master@{#482545} Committed: https://chromium.googlesource.com/chromium/src/+/58289583dc8e3a0ebf327e5410cdabf344e9b816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -15 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 7 chunks +18 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Zhenyao Mo
kbr,kainino: PTAL
3 years, 5 months ago (2017-06-27 01:00:15 UTC) #3
Kai Ninomiya
lgtm
3 years, 5 months ago (2017-06-27 01:04:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959893002/1
3 years, 5 months ago (2017-06-27 05:53:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/58289583dc8e3a0ebf327e5410cdabf344e9b816
3 years, 5 months ago (2017-06-27 05:56:55 UTC) #12
Ken Russell (switch to Gerrit)
3 years, 5 months ago (2017-06-27 21:07:13 UTC) #13
Message was sent while issue was closed.
Thanks for fixing this Mo. LGTM after the fact.

Powered by Google App Engine
This is Rietveld 408576698