Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

Issue 2959893002: FramebufferRenderbuffer() generates INVALID_OP if renderbuffer has never been bound. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "gpu/command_buffer/common/gles2_cmd_format.h" 8 #include "gpu/command_buffer/common/gles2_cmd_format.h"
9 #include "gpu/command_buffer/common/gles2_cmd_utils.h" 9 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
10 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h" 10 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h"
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 attach_cmd.Init(client_program_id_, client_shader_id_); 126 attach_cmd.Init(client_program_id_, client_shader_id_);
127 EXPECT_EQ(error::kNoError, ExecuteCmd(attach_cmd)); 127 EXPECT_EQ(error::kNoError, ExecuteCmd(attach_cmd));
128 } 128 }
129 }; 129 };
130 130
131 template <> 131 template <>
132 void GLES2DecoderTestBase::SpecializedSetup<cmds::FramebufferRenderbuffer, 0>( 132 void GLES2DecoderTestBase::SpecializedSetup<cmds::FramebufferRenderbuffer, 0>(
133 bool valid) { 133 bool valid) {
134 DoBindFramebuffer(GL_FRAMEBUFFER, client_framebuffer_id_, 134 DoBindFramebuffer(GL_FRAMEBUFFER, client_framebuffer_id_,
135 kServiceFramebufferId); 135 kServiceFramebufferId);
136 DoBindRenderbuffer(GL_RENDERBUFFER, client_renderbuffer_id_,
137 kServiceRenderbufferId);
136 if (valid) { 138 if (valid) {
137 EXPECT_CALL(*gl_, GetError()) 139 EXPECT_CALL(*gl_, GetError())
138 .WillOnce(Return(GL_NO_ERROR)) 140 .WillOnce(Return(GL_NO_ERROR))
139 .WillOnce(Return(GL_NO_ERROR)) 141 .WillOnce(Return(GL_NO_ERROR))
140 .RetiresOnSaturation(); 142 .RetiresOnSaturation();
141 } 143 }
142 }; 144 };
143 145
144 template <> 146 template <>
145 void GLES2DecoderTestBase::SpecializedSetup<cmds::FramebufferTextureLayer, 0>( 147 void GLES2DecoderTestBase::SpecializedSetup<cmds::FramebufferTextureLayer, 0>(
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 .Times(1) 200 .Times(1)
199 .RetiresOnSaturation(); 201 .RetiresOnSaturation();
200 } 202 }
201 } 203 }
202 204
203 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h" 205 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h"
204 206
205 } // namespace gles2 207 } // namespace gles2
206 } // namespace gpu 208 } // namespace gpu
207 209
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698