gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc - Issue 2959893002: FramebufferRenderbuffer() generates INVALID_OP if renderbuffer has never been bound.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

Issue 2959893002: FramebufferRenderbuffer() generates INVALID_OP if renderbuffer has never been bound. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

index 7a0d658d79a0a7326cdb86b6e127832641d0d448..0cbd66ec015ca1daf22df58177cbc388f7aa3dbb 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc

@@ -133,6 +133,8 @@ void GLES2DecoderTestBase::SpecializedSetup<cmds::FramebufferRenderbuffer, 0>(

bool valid) {

DoBindFramebuffer(GL_FRAMEBUFFER, client_framebuffer_id_,

kServiceFramebufferId);

+ DoBindRenderbuffer(GL_RENDERBUFFER, client_renderbuffer_id_,

+ kServiceRenderbufferId);

if (valid) {

EXPECT_CALL(*gl_, GetError())

.WillOnce(Return(GL_NO_ERROR))