Use ContainsValue() instead of std::find() in chrome/browser and chrome/common

Use ContainsValue() instead of std::find() in chrome/browser and chrome/common

BUG=561800
Review-Url: https://codereview.chromium.org/2958223002
Cr-Commit-Position: refs/heads/master@{#483327}
Committed: https://chromium.googlesource.com/chromium/src/+/c49d42acc2a3172e1592ff61d984132b113228fa

[Tripta, 2017-06-28 07:32:47]

Description was changed from

==========
Use ContainsValue() instead of std::find() in chrome/browser and chrome/common

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in chrome/browser and chrome/common

BUG=561800
==========

[Tripta, 2017-06-28 07:32:47]

tripta.g@samsung.com changed reviewers:
+ thakis@chromium.org

[Tripta, 2017-06-28 07:33:38]

Hi thakis,

Please review code changes for below files:

  chrome/browser/apps/guest_view/web_view_browsertest.cc
  chrome/browser/content_settings/tab_specific_content_settings.cc
  chrome/browser/custom_handlers/protocol_handler_registry.cc
  chrome/browser/internal_auth.cc
  chrome/browser/lifetime/browser_close_manager.cc
  chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc
  chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
  chrome/browser/spellchecker/spellcheck_service.cc
  chrome/browser/spellchecker/spellcheck_service_unittest.cc
  chrome/browser/translate/translate_manager_render_view_host_unittest.cc
  chrome/common/extensions/command_unittest.cc

Regards
Tripta

[Nico, 2017-06-28 13:55:29]

lgtm with comments addressed

https://codereview.chromium.org/2958223002/diff/1/chrome/browser/lifetime/bro...
File chrome/browser/lifetime/browser_close_manager.cc (right):

https://codereview.chromium.org/2958223002/diff/1/chrome/browser/lifetime/bro...
chrome/browser/lifetime/browser_close_manager.cc:183:
DCHECK(!base::ContainsValue(*(BrowserList::GetInstance()), browser));
remove parens around BrowserList::GetInstance()

https://codereview.chromium.org/2958223002/diff/1/chrome/browser/predictors/a...
File chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
(right):

https://codereview.chromium.org/2958223002/diff/1/chrome/browser/predictors/a...
chrome/browser/predictors/autocomplete_action_predictor_unittest.cc:338: bool
in_expected = (base::ContainsValue(expected, *it));
remove parens around base::ContainsValue()

https://codereview.chromium.org/2958223002/diff/1/chrome/browser/predictors/a...
chrome/browser/predictors/autocomplete_action_predictor_unittest.cc:339: bool
in_list = (base::ContainsValue(id_list, *it));
remove parens around base::ContainsValue()

[Tripta, 2017-06-29 07:10:14]

The CQ bit was checked by tripta.g@samsung.com

[Tripta, 2017-06-29 07:10:15]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2958223002/#ps20001
(title: "Fixed code review changes.")

[commit-bot: I haz the power, 2017-06-29 07:10:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 07:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 07:12:39]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Tripta, 2017-06-29 08:49:57]

The CQ bit was checked by tripta.g@samsung.com

[Tripta, 2017-06-29 08:49:58]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2958223002/#ps40001
(title: "Rebase patch.")

[commit-bot: I haz the power, 2017-06-29 08:50:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tripta, 2017-06-29 08:53:11]

Changes added. Please check.

https://codereview.chromium.org/2958223002/diff/1/chrome/browser/lifetime/bro...
File chrome/browser/lifetime/browser_close_manager.cc (right):

https://codereview.chromium.org/2958223002/diff/1/chrome/browser/lifetime/bro...
chrome/browser/lifetime/browser_close_manager.cc:183:
DCHECK(!base::ContainsValue(*(BrowserList::GetInstance()), browser));
On 2017/06/28 13:55:28, Nico (vacation Jun 30-Jul 11) wrote:
> remove parens around BrowserList::GetInstance()

Done.

https://codereview.chromium.org/2958223002/diff/1/chrome/browser/predictors/a...
File chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
(right):

https://codereview.chromium.org/2958223002/diff/1/chrome/browser/predictors/a...
chrome/browser/predictors/autocomplete_action_predictor_unittest.cc:338: bool
in_expected = (base::ContainsValue(expected, *it));
On 2017/06/28 13:55:28, Nico (vacation Jun 30-Jul 11) wrote:
> remove parens around base::ContainsValue()

Done.

https://codereview.chromium.org/2958223002/diff/1/chrome/browser/predictors/a...
chrome/browser/predictors/autocomplete_action_predictor_unittest.cc:339: bool
in_list = (base::ContainsValue(id_list, *it));
On 2017/06/28 13:55:28, Nico (vacation Jun 30-Jul 11) wrote:
> remove parens around base::ContainsValue()

Done.

[commit-bot: I haz the power, 2017-06-29 09:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 09:04:00]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-06-29 10:53:38]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-06-29 10:53:38]

lgtm

[commit-bot: I haz the power, 2017-06-29 10:53:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 11:45:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498733618086270,
"parent_rev": "9e2eff2da3ae0a6f4235f1aaabbb4d02c94b1554", "commit_rev":
"c49d42acc2a3172e1592ff61d984132b113228fa"}

[commit-bot: I haz the power, 2017-06-29 11:45:20]

Description was changed from

==========
Use ContainsValue() instead of std::find() in chrome/browser and chrome/common

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in chrome/browser and chrome/common

BUG=561800

Review-Url: https://codereview.chromium.org/2958223002
Cr-Commit-Position: refs/heads/master@{#483327}
Committed:
https://chromium.googlesource.com/chromium/src/+/c49d42acc2a3172e1592ff61d984...
==========

[commit-bot: I haz the power, 2017-06-29 11:45:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c49d42acc2a3172e1592ff61d984...