chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc - Issue 2958223002: Use ContainsValue() instead of std::find() in chrome/browser and chrome/common

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc

Issue 2958223002: Use ContainsValue() instead of std::find() in chrome/browser and chrome/common (Closed)

Patch Set: Rebase patch. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/lifetime/browser_close_manager.cc ('k') | chrome/browser/predictors/autocomplete_action_predictor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc

diff --git a/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc b/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc

index 5c0e57da0414ae1edf895399035c85f4c0353431..0828ef3cf358e6d7e9c1b88b0d29eca41e9ff3c9 100644

--- a/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc

+++ b/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc

@@ -8,6 +8,7 @@

#include "base/callback.h"

#include "base/metrics/field_trial.h"

#include "base/run_loop.h"

+#include "base/stl_util.h"

#include "base/test/scoped_feature_list.h"

#include "chrome/browser/content_settings/host_content_settings_map_factory.h"

#include "chrome/browser/content_settings/tab_specific_content_settings.h"

@@ -75,8 +76,7 @@ class MediaStreamDevicesControllerTest

size_t TotalRequestCount() { return last_requests_.size(); }

bool WasRequested(ContentSettingsType type) {

- return std::find(last_requests_.begin(), last_requests_.end(), type) !=

- last_requests_.end();

+ return base::ContainsValue(last_requests_, type);

}

void Reset() { last_requests_.clear(); }