Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4496)

Unified Diff: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

Issue 2958223002: Use ContainsValue() instead of std::find() in chrome/browser and chrome/common (Closed)
Patch Set: Rebase patch. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_render_view_host_unittest.cc
diff --git a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
index 885527d9b70639e23ea0b21ce3a97236b9368717..dc6ffec7d35a16ac013af5522c33190a93b8df0a 100644
--- a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
+++ b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
@@ -4,7 +4,6 @@
#include <stddef.h>
-#include <algorithm>
#include <memory>
#include <set>
#include <tuple>
@@ -14,6 +13,7 @@
#include "base/command_line.h"
#include "base/macros.h"
#include "base/run_loop.h"
+#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
#include "build/build_config.h"
#include "chrome/app/chrome_command_ids.h"
@@ -608,9 +608,7 @@ TEST_F(TranslateManagerRenderViewHostTest, FetchLanguagesFromTranslateServer) {
const std::string& lang = server_languages[i];
if (lang == "xx")
continue;
- EXPECT_NE(current_supported_languages.end(),
- std::find(current_supported_languages.begin(),
- current_supported_languages.end(), lang))
+ EXPECT_TRUE(base::ContainsValue(current_supported_languages, lang))
<< "lang=" << lang;
}
}
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_service_unittest.cc ('k') | chrome/common/extensions/command_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698